-
-
Notifications
You must be signed in to change notification settings - Fork 754
✨ Add overload for exec
method to support insert
, update
, delete
statements
#1342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
On #1349 you asked for feedbacks on your PR: I tested it and it fixed my typing errors! Previously I had this mypy output:
After applying your patch, the type error is solved. |
Hope this gets merged soon! Good job @seriaati |
exec
method to support insert
, update
, delete
statements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This fixes the typing issue when we use exec
method with insert
, update
or delete
statements. Currently it works, but type checkers raise warnings. This PR fixes this.
@seriaati, thanks for working on this!
To address #909