🐛 Fix composite primary with AfterValidator/Annotated #1602
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick91
force-pushed
the
10-09-_fix_composite_primary_with_aftervalidator_annotated
branch
from
9b502f9 to
25d3e9c
Compare
|
I have also being working on solving this and will make a PR solving the issue with the associated tests. I will link it here when its done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title is currently a lie :D but there's a test for what's broken, and I think it's because the FieldInfo we get in
get_column_from_fieldis the Pydantic one and not the SQLModel oneEDIT: I guess this is not just about primary keys, but it's about any custom attribute used in SQLModel's
Field:)