Skip to content

Conversation

@Gravecat
Copy link
Contributor

Fixes errors when trying to compile with GCC/MinGW.

@Gravecat
Copy link
Contributor Author

Realized I should probably clarify, as this is a weird situation. :) This PR fixes compiler errors when trying to cross-compile to a Windows binary using MinGW on Linux (or WSL). In this situation, _WIN64, __MINGW64__ and __GNUC__ are all defined by the toolchain.

_umul128 doesn't get defined because of the #if !defined(__MINGW64__) check earlier, so we end up with error: ‘_umul128’ was not declared in this scope. With this additional change, the problem is bypassed.

@lemire
Copy link
Member

lemire commented Nov 23, 2025

Merging. This will be part of the next release.

@lemire lemire merged commit f8c573d into fastfloat:main Nov 23, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants