Skip to content

fix: add 'limit' event to BusboyFileStream typings#191

Merged
Eomm merged 4 commits intofastify:mainfrom
williamfds:fix/add-limit-event
Nov 10, 2025
Merged

fix: add 'limit' event to BusboyFileStream typings#191
Eomm merged 4 commits intofastify:mainfrom
williamfds:fix/add-limit-event

Conversation

@williamfds
Copy link
Copy Markdown
Contributor

Closes #173

This PR adds the limit event to the BusboyFileStream typings so that consumers can listen for file‐size limit breaches.
It also includes:

  • A unit test (test/file-stream-limit.test.js) that verifies the limit event is emitted.
  • Documentation in README.md showing how to use the event.
  • tap and @types/tap added to devDependencies to support the new test.

Checklist

gurgunday
gurgunday previously approved these changes Jun 1, 2025
Comment thread package.json Outdated
@williamfds williamfds requested review from Eomm and gurgunday June 2, 2025 11:18
@gurgunday
Copy link
Copy Markdown
Member

Why didn't the CI run?

Signed-off-by: Manuel Spigolon <behemoth89@gmail.com>
@Eomm Eomm merged commit 0207df2 into fastify:main Nov 10, 2025
14 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TypeScript] Missing event "limit" on BusboyFileStream

3 participants