Skip to content

Conversation

@jmjf
Copy link
Contributor

@jmjf jmjf commented Jun 29, 2024

Generates JWTs dynamically in tests as requested by @mcollina on #335.

If there's a way to apply this change to the original PR, please point me toward it and I'll do it.

This PR includes the changes @NikitaFedorov1 made for PR 335. My understanding of his comment in 335 is that he does not intend to apply the test changes requested. I just changed a few lines in his tests (commit #5) so others can get the benefit of this fix.

I broke the tests several times before getting them right, so I know they can fail. 😄 Also confirmed response bodies/error details matched those from the hard coded tokens while working on the tests.

PR 335 description

False positive tests: test: Async key provider errors should be resolved internally

Fix & test fix: feat: Async key provider

Related issue: #334

Checklist

@NikitaIT
Copy link
Contributor

Yes, I've been very busy lately and I completely forgot about it. It looks good. Thank you. Just hold this pr instead of mine.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit ad9317b into fastify:master Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants