Skip to content

Revert Tool PRs#1762

Merged
rcaril merged 1 commit intomainfrom
rcaril/revert-dependabot-tool-merges
Apr 27, 2026
Merged

Revert Tool PRs#1762
rcaril merged 1 commit intomainfrom
rcaril/revert-dependabot-tool-merges

Conversation

@rcaril
Copy link
Copy Markdown
Member

@rcaril rcaril commented Apr 27, 2026

Change summary

Reverts the transitive dependency bumps introduced by PRs #1739#1753
which broke go tool -modfile=tools/go.mod goreleaser check due to
an incompatibility between goreleaser v2.9.0 and the newer
gitlab-org/api/client-go (v0.143.3) pulled in transitively by the
sigstore/cosign bump (#1753).
All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Are there any considerations that need to be addressed for release?

We'll need to do a fast follow up PR after this to correct the go-releaser format deprecations.

… state

 Reverts the transitive dependency bumps introduced by PRs #1739#1753
   which broke `go tool -modfile=tools/go.mod goreleaser check` due to
   an incompatibility between goreleaser v2.9.0 and the newer
   gitlab-org/api/client-go (v0.143.3) pulled in transitively by the
   sigstore/cosign bump (#1753).
@rcaril rcaril added the Skip-Changelog do not add a changelog entry for this change label Apr 27, 2026
@rcaril rcaril requested a review from a team as a code owner April 27, 2026 18:49
@rcaril rcaril requested a review from jedisct1 April 27, 2026 18:49
@rcaril rcaril enabled auto-merge (squash) April 27, 2026 19:01
@rcaril rcaril merged commit d2472a1 into main Apr 27, 2026
13 of 19 checks passed
@rcaril rcaril deleted the rcaril/revert-dependabot-tool-merges branch April 27, 2026 19:04
rcaril added a commit that referenced this pull request Apr 27, 2026
### Change summary

This PR is a fast follow up to #1762 - we are replacing deprecated
archives.builds and archives.format properties in `.goreleaser.yml` .

 All Submissions:

* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?

<!-- You can erase any parts of this template not applicable to your
Pull Request. -->

### New Feature Submissions:

* [x] Does your submission pass tests?
@rcaril rcaril mentioned this pull request Apr 28, 2026
3 tasks
rcaril added a commit that referenced this pull request Apr 28, 2026
### Change summary

Since we skip any release steps for all PRs that aren't tagged as a
release, we need to add a CI job to test `goreleaser` tools builds
against Dependabot PRs. This ensures that future dependency PRs opened
will validate that they do not conflict with the current version of
`goreleaser` to prevent scenarios like #1762.

 All Submissions:

* [x] Have you followed the guidelines in our Contributing document?
* [x] Have you checked to ensure there aren't other open [Pull
Requests](https://github.com/fastly/cli/pulls) for the same
update/change?

<!-- You can erase any parts of this template not applicable to your
Pull Request. -->

### New Feature Submissions:

* [x] Does your submission pass tests?

### Notes:

We are only testing against `ubuntu-latest` as we are just looking for
collision errors, which should be available on any architecture. So this
should be sufficient for this use case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Changelog do not add a changelog entry for this change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants