Conversation
Collaborator
Author
|
Fixes #58 |
Member
|
looks like you've got some conflicts to fix here now |
zkat
reviewed
Aug 18, 2025
| INTERPROCEDURAL_OPTIMIZATION ${LTO_SUPPORTED}) | ||
| target_link_options(fastly-thin PRIVATE ${FASTLY_LDFLAGS}) | ||
|
|
||
| target_compile_options(fastly-thin PRIVATE -Wall -Wextra -Werror ${FASTLY_CXXFLAGS}) |
Member
There was a problem hiding this comment.
oh. I guess we're not using MSVC at all since it's always clang huh
| configure_file(${f} ${DIST_DIR}/fastly/${fr} COPYONLY) | ||
| list(APPEND incls "#include \"${fr}\"\n") | ||
| file(RELATIVE_PATH fr "${CMAKE_CURRENT_SOURCE_DIR}/include" ${f}) | ||
| list(APPEND incls "#include <${fr}>\n") |
Member
There was a problem hiding this comment.
I thought <foo> was only for "system" files?
Collaborator
Author
There was a problem hiding this comment.
I tend to use the rule of quotes for relative includes, angle brackets for absolute includes. Public headers are always absolute, cause it avoids differences between the in-build tree and the installed tree. In this particular case, it avoids the need to copy expected.h into the same place as the other public headers when building. See also Core Guideline SF.12
zkat
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the modularity and utility of the build system
distoutput folder with install targetsfind_packagescenariosfind_packagerather than manual linkingvcpkgport for the SDK in the future