Conversation
Collaborator
Author
zkat
approved these changes
Sep 3, 2025
Member
zkat
left a comment
zkat
left a comment
There was a problem hiding this comment.
This is so great. This was a pretty big API to tackle, and the stuff you've been doing made it look so clean. Also! We have tests now! what!!
| } | ||
|
|
||
| SECTION("erase") { | ||
| REQUIRE(store.insert(key, std::move(value_body))); |
Member
There was a problem hiding this comment.
I think I don't understand std::move enough here. How are you moving the same value multiple times?
Collaborator
Author
There was a problem hiding this comment.
The SECTIONs are run separately and the code at the top level of the TEST_CASE is run once for each of them, so the value_bodys in each SECTION are distinct
| ) -> bool; | ||
| // Needed to force generation of `drop`. | ||
| fn f_header_values_iter_noop(val: Box<HeaderValuesIter>) -> Box<HeaderValuesIter>; | ||
| fn f_header_values_iter_force_symbols(val: Box<HeaderValuesIter>) -> Box<HeaderValuesIter>; |
zkat
added
feature
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The testing suite just covers the KV store API for now, more to come in a future PR