Conversation
zkat
approved these changes
Sep 15, 2025
Member
zkat
left a comment
zkat
left a comment
There was a problem hiding this comment.
this is all kind of amazing tbh. Approving with some optional nits :)
| cmake_minimum_required(VERSION 3.29) | ||
|
|
||
| project(compute-sdk-cpp VERSION 0.3.0 LANGUAGES CXX) | ||
| project(compute-sdk-cpp VERSION 0.4.0 LANGUAGES CXX) |
Member
There was a problem hiding this comment.
this is fine for this PR, but I think we should generally leave version bumps to releases.
| ) | ||
| }; | ||
| match result { | ||
| 1 => Ok(unsafe { esi::PendingFragmentContent::PendingRequest(out_pending.read().0) }), |
Member
There was a problem hiding this comment.
Could you use an enum for this? Enums in Rust can have integer reprs:
#[repr(u8)]
enum Foo {
Val1 = 1,
Val2
}
match Foo::Val1 as u8 {
1 => ...,
_ => ...,
}
Collaborator
Author
|
Fixes #56 |
zkat
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.