Conversation
zkat
approved these changes
Mar 16, 2026
|
It will be nice to add examples for these new APIs. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the Core Cache API, based on the Rust implementation, but calling hostcalls directly.
Most of this is a fairly mechanical translation from the Rust SDK. The tricky part is where the existing Rust types (
StreamingBody) are required, in which case we need to retrieve handles from host calls, then pass those through Rust and get back a C++-wrapped Rust object to return to the user. This is a pattern we'll have to do elsewhere if we decide to piecemeal move away from wrapping the Rust SDK and prefer making hostcalls ourselves.This is currently lacking any testing: I haven't even tried to load it into Viceroy.