Merged
Conversation
zkat
approved these changes
Apr 29, 2026
zkat
force-pushed
the
sy/body-read-all-large
branch
3 times, most recently
from
1f610fc to
9c57fba
Compare
zkat
force-pushed
the
sy/body-read-all-large
branch
from
da869ed to
0be29ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the buffer allocated for
HttpBody::read_allis of a fixed size. We do check for overflow, but we do this check after writing into the buffer, so we potentially leak returned data somewhere else in memory before returning an error. This PR makes the buffer dynamically-sized, and performs overflow checks earlier.We also could potentially hit issues with 0-length bodies. Currently, this pattern should never be hit, as we only call this function for ACL lookups and KV store lists, which return non-empty JSON in all paths, so there's no test for this behaviour; it is simply being defensive against future host changes or new uses of
read_all.