Skip to content

fix: Numeric overflow issue in Core Cache API #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TartanLlama wants to merge 3 commits into
base: main
Choose a base branch
from
+187 −10
Open

fix: Numeric overflow issue in Core Cache API #1448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8d0453
Fix overflow issue
TartanLlama Apr 30, 2026
1bdc102
fmt
TartanLlama Apr 30, 2026
bb7466b
Merge branch 'main' into sy/core-cache-overflow
zkat May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
143 changes: 143 additions & 0 deletions integration-tests/js-compute/fixtures/app/src/cache-core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1722,6 +1722,16 @@ function ensureLion() {
});
},
);
routes.set(
'/core-cache/insert/options-parameter-maxAge-field-too-large',
() => {
assertThrows(() => {
CoreCache.insert('cat', {
maxAge: 2e13,
});
});
},
);
routes.set(
'/core-cache/insert/options-parameter-initialAge-field-valid-record',
() => {
Expand Down Expand Up @@ -1780,6 +1790,17 @@ function ensureLion() {
});
},
);
routes.set(
'/core-cache/insert/options-parameter-initialAge-field-too-large',
() => {
assertThrows(() => {
CoreCache.insert('cat', {
maxAge: 1,
initialAge: 2e13,
});
});
},
);
routes.set(
'/core-cache/insert/options-parameter-staleWhileRevalidate-field-valid-record',
() => {
Expand Down Expand Up @@ -1841,6 +1862,17 @@ function ensureLion() {
});
},
);
routes.set(
'/core-cache/insert/options-parameter-staleWhileRevalidate-field-too-large',
() => {
assertThrows(() => {
CoreCache.insert('cat', {
maxAge: 1,
staleWhileRevalidate: 2e13,
});
});
},
);
routes.set(
'/core-cache/insert/options-parameter-length-field-valid-record',
() => {
Expand Down Expand Up @@ -3768,6 +3800,17 @@ function ensureLion() {
});
},
);
routes.set(
'/transaction-cache-entry/insert/options-parameter-maxAge-field-too-large',
() => {
assertThrows(() => {
let entry = CoreCache.transactionLookup('1');
entry.insert({
maxAge: 2e13,
});
});
},
);
routes.set(
'/transaction-cache-entry/insert/options-parameter-initialAge-field-valid-record',
() => {
Expand Down Expand Up @@ -3831,6 +3874,18 @@ function ensureLion() {
});
},
);
routes.set(
'/transaction-cache-entry/insert/options-parameter-initialAge-field-too-large',
() => {
assertThrows(() => {
let entry = CoreCache.transactionLookup('1');
entry.insert({
maxAge: 1,
initialAge: 2e13,
});
});
},
);
routes.set(
'/transaction-cache-entry/insert/options-parameter-staleWhileRevalidate-field-valid-record',
() => {
Expand Down Expand Up @@ -3894,6 +3949,18 @@ function ensureLion() {
});
},
);
routes.set(
'/transaction-cache-entry/insert/options-parameter-staleWhileRevalidate-field-too-large',
() => {
assertThrows(() => {
let entry = CoreCache.transactionLookup('1');
entry.insert({
maxAge: 1,
staleWhileRevalidate: 2e13,
});
});
},
);
routes.set(
'/transaction-cache-entry/insert/options-parameter-length-field-valid-record',
() => {
Expand Down Expand Up @@ -4080,6 +4147,18 @@ function ensureLion() {
});
},
);
routes.set(
'/transaction-cache-entry/insertAndStreamBack/options-parameter-maxAge-field-too-large',
(event) => {
const path = new URL(event.request.url).pathname;
assertThrows(() => {
let entry = CoreCache.transactionLookup(path);
entry.insertAndStreamBack({
maxAge: 2e13,
});
});
},
);
routes.set(
'/transaction-cache-entry/insertAndStreamBack/options-parameter-initialAge-field-valid-record',
(event) => {
Expand Down Expand Up @@ -4157,6 +4236,19 @@ function ensureLion() {
});
},
);
routes.set(
'/transaction-cache-entry/insertAndStreamBack/options-parameter-initialAge-field-too-large',
(event) => {
const path = new URL(event.request.url).pathname;
assertThrows(() => {
let entry = CoreCache.transactionLookup(path);
entry.insertAndStreamBack({
maxAge: 1,
initialAge: 2e13,
});
});
},
);
routes.set(
'/transaction-cache-entry/insertAndStreamBack/options-parameter-staleWhileRevalidate-field-valid-record',
(event) => {
Expand Down Expand Up @@ -4233,6 +4325,19 @@ function ensureLion() {
});
},
);
routes.set(
'/transaction-cache-entry/insertAndStreamBack/options-parameter-staleWhileRevalidate-field-too-large',
(event) => {
const path = new URL(event.request.url).pathname;
assertThrows(() => {
let entry = CoreCache.transactionLookup(path);
entry.insertAndStreamBack({
maxAge: 1,
staleWhileRevalidate: 2e13,
});
});
},
);
routes.set(
'/transaction-cache-entry/insertAndStreamBack/options-parameter-length-field-valid-record',
(event) => {
Expand Down Expand Up @@ -4444,6 +4549,18 @@ function ensureLion() {
});
},
);
routes.set(
'/transaction-cache-entry/update/options-parameter-maxAge-field-too-large',
(event) => {
const path = new URL(event.request.url).pathname;
assertThrows(() => {
let entry = CoreCache.transactionLookup(path);
entry.update({
maxAge: 2e13,
});
});
},
);
routes.set(
'/transaction-cache-entry/update/options-parameter-initialAge-field-valid-record',
(event) => {
Expand Down Expand Up @@ -4512,6 +4629,19 @@ function ensureLion() {
});
},
);
routes.set(
'/transaction-cache-entry/update/options-parameter-initialAge-field-too-large',
(event) => {
const path = new URL(event.request.url).pathname;
assertThrows(() => {
let entry = CoreCache.transactionLookup(path);
entry.update({
maxAge: 1,
initialAge: 2e13,
});
});
},
);
routes.set(
'/transaction-cache-entry/update/options-parameter-staleWhileRevalidate-field-valid-record',
(event) => {
Expand Down Expand Up @@ -4580,6 +4710,19 @@ function ensureLion() {
});
},
);
routes.set(
'/transaction-cache-entry/update/options-parameter-staleWhileRevalidate-field-too-large',
(event) => {
const path = new URL(event.request.url).pathname;
assertThrows(() => {
let entry = CoreCache.transactionLookup(path);
entry.update({
maxAge: 1,
staleWhileRevalidate: 2e13,
});
});
},
);
routes.set(
'/transaction-cache-entry/update/options-parameter-length-field-valid-record',
(event) => {
Expand Down
36 changes: 36 additions & 0 deletions integration-tests/js-compute/fixtures/app/tests.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1931,6 +1931,9 @@
"GET /core-cache/insert/options-parameter-maxAge-field-negative-number": {
"environments": ["compute"]
},
"GET /core-cache/insert/options-parameter-maxAge-field-too-large": {
"environments": ["compute"]
Comment thread
zkat marked this conversation as resolved.
},
"GET /core-cache/insert/options-parameter-initialAge-field-valid-record": {
"environments": ["compute"]
},
Expand All @@ -1946,6 +1949,9 @@
"GET /core-cache/insert/options-parameter-initialAge-field-negative-number": {
"environments": ["compute"]
},
"GET /core-cache/insert/options-parameter-initialAge-field-too-large": {
"environments": ["compute"]
},
"GET /core-cache/insert/options-parameter-staleWhileRevalidate-field-valid-record": {
"flake": true,
"environments": ["compute"]
Expand All @@ -1962,6 +1968,9 @@
"GET /core-cache/insert/options-parameter-staleWhileRevalidate-field-negative-number": {
"environments": ["compute"]
},
"GET /core-cache/insert/options-parameter-staleWhileRevalidate-field-too-large": {
"environments": ["compute"]
},
"GET /core-cache/insert/options-parameter-length-field-valid-record": {
"environments": ["compute"]
},
Expand Down Expand Up @@ -2185,6 +2194,9 @@
"GET /transaction-cache-entry/insert/options-parameter-maxAge-field-negative-number": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insert/options-parameter-maxAge-field-too-large": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insert/options-parameter-initialAge-field-valid-record": {
"flake": true,
"environments": ["compute"]
Expand All @@ -2201,6 +2213,9 @@
"GET /transaction-cache-entry/insert/options-parameter-initialAge-field-negative-number": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insert/options-parameter-initialAge-field-too-large": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insert/options-parameter-staleWhileRevalidate-field-valid-record": {
"flake": true,
"environments": ["compute"]
Expand All @@ -2217,6 +2232,9 @@
"GET /transaction-cache-entry/insert/options-parameter-staleWhileRevalidate-field-negative-number": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insert/options-parameter-staleWhileRevalidate-field-too-large": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insert/options-parameter-length-field-valid-record": {
"flake": true,
"environments": ["compute"]
Expand Down Expand Up @@ -2262,6 +2280,9 @@
"GET /transaction-cache-entry/insertAndStreamBack/options-parameter-maxAge-field-negative-number": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insertAndStreamBack/options-parameter-maxAge-field-too-large": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insertAndStreamBack/options-parameter-initialAge-field-valid-record": {
"environments": ["compute"]
},
Expand All @@ -2277,6 +2298,9 @@
"GET /transaction-cache-entry/insertAndStreamBack/options-parameter-initialAge-field-negative-number": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insertAndStreamBack/options-parameter-initialAge-field-too-large": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insertAndStreamBack/options-parameter-staleWhileRevalidate-field-valid-record": {
"environments": ["compute"]
},
Expand All @@ -2292,6 +2316,9 @@
"GET /transaction-cache-entry/insertAndStreamBack/options-parameter-staleWhileRevalidate-field-negative-number": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insertAndStreamBack/options-parameter-staleWhileRevalidate-field-too-large": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/insertAndStreamBack/options-parameter-length-field-valid-record": {
"environments": ["compute"]
},
Expand Down Expand Up @@ -2337,6 +2364,9 @@
"GET /transaction-cache-entry/update/options-parameter-maxAge-field-negative-number": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/update/options-parameter-maxAge-field-too-large": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/update/options-parameter-initialAge-field-valid-record": {
"environments": ["compute"]
},
Expand All @@ -2352,6 +2382,9 @@
"GET /transaction-cache-entry/update/options-parameter-initialAge-field-negative-number": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/update/options-parameter-initialAge-field-too-large": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/update/options-parameter-staleWhileRevalidate-field-valid-record": {
"environments": ["compute"]
},
Expand All @@ -2367,6 +2400,9 @@
"GET /transaction-cache-entry/update/options-parameter-staleWhileRevalidate-field-negative-number": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/update/options-parameter-staleWhileRevalidate-field-too-large": {
"environments": ["compute"]
},
"GET /transaction-cache-entry/update/options-parameter-length-field-valid-record": {
"environments": ["compute"]
},
Expand Down
Loading
Loading