Skip to content

PagerDuty: reduce the number of incidents update at once, match PD docs #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rjbs merged 2 commits into from
Dec 23, 2025
Merged

PagerDuty: reduce the number of incidents update at once, match PD docs #283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fe6723
PagerDuty: tweak signatures to match house style
rjbs Dec 20, 2025
d63f70d
PagerDuty: update fewer events at once
rjbs Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions lib/Synergy/Reactor/PagerDuty.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,7 @@ sub _check_long_maint ($self) {
})->retain;
}

sub _oncall_tree($self) {
sub _oncall_tree ($self) {

my %should_ignore = map {; $_ => 1 } $self->suppressed_user_ids;

Expand Down Expand Up @@ -912,9 +912,8 @@ sub _update_status_for_incidents ($self, $who, $status, $incident_ids) {
my @todo = @$incident_ids;
my @incidents;

# *Surely* we won't have more than 500 at a time, right? Right?! Anyway,
# 500 is the PagerDuty max for this endpoint.
while (my @ids = splice @todo, 0, 500) {
# The PagerDuty API will reject updates for over 250 items.
while (my @ids = splice @todo, 0, 250) {
my @put = map {;
+{
id => $_,
Expand Down Expand Up @@ -952,7 +951,7 @@ sub _ack_all ($self, $event) {
});
}

sub _resolve_incidents($self, $event, $arg) {
sub _resolve_incidents ($self, $event, $arg) {
my $whose = $arg->{whose};
my $only_pending = $arg->{only_pending};
Carp::confess("_resolve_incidents called with bogus args")
Expand Down
Loading