Add extra offset when navcontroller is in a tabbar controller#27
Open
SamuraiZack wants to merge 1 commit intofastred:masterfrom
Open
Add extra offset when navcontroller is in a tabbar controller#27SamuraiZack wants to merge 1 commit intofastred:masterfrom
SamuraiZack wants to merge 1 commit intofastred:masterfrom
Conversation
|
This patch has bugs, will made the navcontroller in tabBarcontroller offset wrong |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be some offset issue when a viewcontroller is pushed from a navigation controller inside a tabbar controller. This will fix the center offset and will only work correctly if the sloppy swiper delegate is used and returns false on animatorShouldAnimateTabBar.