Skip to content

Polish settings account and audio active states #4797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ComputelessComputer merged 1 commit into from
Mar 28, 2026
Merged

Polish settings account and audio active states #4797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/settings/general/account.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export function SettingsAccount() {

return (
<div className="flex flex-col gap-8">
<section className="border-b border-neutral-200 pb-4">
<section className="pb-4">
<div className="flex flex-col gap-6 sm:flex-row sm:items-center sm:justify-between">
<div className="flex min-w-0 flex-1 flex-col gap-4">
<h2 className="font-serif text-lg font-semibold">Account</h2>
Expand Down
27 changes: 22 additions & 5 deletions apps/desktop/src/settings/general/audio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,16 +162,33 @@ function DeviceItem({
"flex cursor-grab items-center gap-2 rounded-lg px-3 py-2 active:cursor-grabbing",
"border transition-colors",
isTop
? "border-neutral-300 bg-neutral-100"
? "border-green-200 bg-green-50"
: "border-neutral-200 bg-neutral-50 hover:bg-neutral-100",
])}
>
<GripVertical className="h-4 w-4 shrink-0 text-neutral-400" />
<span className="w-4 text-xs text-neutral-400">{rank}</span>
<span className={cn(["flex-1 truncate text-sm", isTop && "font-medium"])}>
<GripVertical
className={cn([
"h-4 w-4 shrink-0",
isTop ? "text-green-500" : "text-neutral-400",
])}
/>
<span
className={cn([
"w-4 text-xs",
isTop ? "text-green-500" : "text-neutral-400",
])}
>
{rank}
</span>
<span
className={cn([
"flex-1 truncate text-sm",
isTop && "font-medium text-green-950",
])}
>
{device.name}
</span>
{isTop && <span className="text-xs text-neutral-500">Active</span>}
{isTop && <span className="text-xs text-green-700">Active</span>}
</Reorder.Item>
);
}
Loading