🛡️ Sentinel: [CRITICAL] Fix insecure randomness in coupon and code generation

.jules/sentinel.md

@@ -0,0 +1,4 @@
+## 2024-05-02 - Insecure Randomness in Code Generation
+**Vulnerability:** Weak pseudo-random number generator `Math.random()` was used for generating sensitive items like coupon codes and store credits.
+**Learning:** `Math.random()` is not cryptographically secure and its outputs can be predicted, allowing an attacker to potentially guess valid coupon codes or store credit codes.
+**Prevention:** Always use `generateSecureCode()` from `@/lib/utils` which leverages the Web Crypto API (`crypto.getRandomValues()`) for cryptographically secure randomness.

app/api/bargain/route.ts

@@ -4,6 +4,7 @@ import { db, user, coupons, bargainSessions, products, combos } from "@/lib/db";
 import { and, eq, inArray } from "drizzle-orm";
 import { headers } from "next/headers";
 import { auth } from "@/lib/auth";
+import { generateSecureCode } from "@/lib/utils";
 
 export const maxDuration = 30;
 const MAX_NEGOTIATION_ROUNDS = 10;
@@ -20,12 +21,7 @@ type BargainCartItem = {
 
 // Generate unique coupon code
 function generateCouponCode(): string {
-  const chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
-  let code = "BRG-";
-  for (let i = 0; i < 6; i++) {
-    code += chars.charAt(Math.floor(Math.random() * chars.length));
-  }
-  return code;
+  return generateSecureCode("BRG-", 6);
 }
 
 function calculateCartRuleCap(cartTotal: number, isFirstTimeUser: boolean): number {

lib/actions/admin.ts

@@ -5,6 +5,7 @@ import { products, productVariants, coupons, orders, orderItems } from "@/lib/db
 import { requireAdmin } from "@/lib/auth-server";
 import { eq, desc, sql, and, gte } from "drizzle-orm";
 import { revalidatePath } from "next/cache";
+import { generateSecureCode } from "@/lib/utils";
 
 // ============================================
 // PRODUCT ACTIONS
@@ -567,11 +568,7 @@ export async function issueStoreCredit(data: IssueStoreCreditInput) {
   const creditAmount = Math.round(data.refundAmount * bonusMultiplier);
 
   // Generate unique store credit code
-  const chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
-  let code = "CREDIT-";
-  for (let i = 0; i < 8; i++) {
-    code += chars.charAt(Math.floor(Math.random() * chars.length));
-  }
+  const code = generateSecureCode("CREDIT-", 8);
 
   // Set validity (30-60 days)
   const validityDays = Math.min(Math.max(data.validityDays || 30, 30), 60);

lib/cart-context.tsx

@@ -1,6 +1,7 @@
 "use client"
 
 import { createContext, useContext, useState, useEffect, ReactNode } from "react"
+import { generateSecureCode } from "@/lib/utils"
 
 export interface CartItem {
     id: string
@@ -80,7 +81,7 @@ export function CartProvider({ children }: { children: ReactNode }) {
     }
 
     const addCombo: CartContextType["addCombo"] = (combo) => {
-        const comboGroupId = `combo-${Date.now()}-${Math.random().toString(36).slice(2, 8)}`
+        const comboGroupId = generateSecureCode(`combo-${Date.now()}-`, 6)
         setItems((prev) => [
             ...prev,
             ...combo.items.map((item) => ({

lib/utils.ts

@@ -4,3 +4,18 @@ import { twMerge } from "tailwind-merge"
 export function cn(...inputs: ClassValue[]) {
   return twMerge(clsx(inputs))
 }
+
+/**
+ * Generates a cryptographically secure random string with the given prefix and length.
+ * Uses the Web Crypto API to ensure sufficient entropy for tokens and secrets.
+ */
+export function generateSecureCode(prefix: string, length: number): string {
+  const chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
+  let result = prefix;
+  const randomValues = new Uint32Array(length);
+  crypto.getRandomValues(randomValues);
+  for (let i = 0; i < length; i++) {
+    result += chars[randomValues[i] % chars.length];
+  }
+  return result;
+}