Skip to content

🎨 Palette: Improve accessibility of cart drawer buttons #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fatelessdev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Improve accessibility of cart drawer buttons #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
## 2026-05-02 - Missing aria-labels on icon-only buttons\n**Learning:** In Next.js applications using shadcn/ui `<Button size="icon">`, accessibility is often overlooked. Screen readers cannot interpret the purpose of a button containing only an icon unless an `aria-label` or visually hidden text (`sr-only`) is provided. This is a common pattern across many files in this codebase.\n**Action:** Add descriptive `aria-label` attributes to all icon-only buttons to ensure they are accessible to users relying on assistive technologies.
3 changes: 3 additions & 0 deletions components/features/cart-drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export function CartDrawer() {
size="icon"
className="h-7 w-7 rounded-none"
onClick={() => updateQuantity(item.id, item.size, item.quantity - 1, item.color, item.comboGroupId)}
aria-label="Decrease quantity"
>
<Minus className="h-3 w-3" />
</Button>
Expand All @@ -126,6 +127,7 @@ export function CartDrawer() {
size="icon"
className="h-7 w-7 rounded-none"
onClick={() => updateQuantity(item.id, item.size, item.quantity + 1, item.color, item.comboGroupId)}
aria-label="Increase quantity"
>
<Plus className="h-3 w-3" />
</Button>
Expand All @@ -136,6 +138,7 @@ export function CartDrawer() {
size="icon"
className="h-7 w-7 self-start text-muted-foreground hover:text-foreground"
onClick={() => removeItem(item.id, item.size, item.color, item.comboGroupId)}
aria-label="Remove item"
>
<X className="h-3.5 w-3.5" />
</Button>
Expand Down