Skip to content

🎨 Palette: Add missing ARIA labels to icon-only buttons #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fatelessdev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🎨 Palette: Add missing ARIA labels to icon-only buttons #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/features/cart-drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export function CartDrawer() {
size="icon"
className="h-7 w-7 rounded-none"
onClick={() => updateQuantity(item.id, item.size, item.quantity - 1, item.color, item.comboGroupId)}
aria-label="Decrease quantity"
>
<Minus className="h-3 w-3" />
</Button>
Expand All @@ -126,6 +127,7 @@ export function CartDrawer() {
size="icon"
className="h-7 w-7 rounded-none"
onClick={() => updateQuantity(item.id, item.size, item.quantity + 1, item.color, item.comboGroupId)}
aria-label="Increase quantity"
>
<Plus className="h-3 w-3" />
</Button>
Expand All @@ -136,6 +138,7 @@ export function CartDrawer() {
size="icon"
className="h-7 w-7 self-start text-muted-foreground hover:text-foreground"
onClick={() => removeItem(item.id, item.size, item.color, item.comboGroupId)}
aria-label="Remove item"
>
<X className="h-3.5 w-3.5" />
</Button>
Expand Down
5 changes: 3 additions & 2 deletions components/layout/navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export function Navbar() {
size="icon"
className="md:hidden mr-2"
onClick={() => setShowMobileMenu(!showMobileMenu)}
aria-label="Toggle mobile menu"
>
{showMobileMenu ? <X className="h-5 w-5" /> : <Menu className="h-5 w-5" />}
</Button>
Expand Down Expand Up @@ -71,10 +72,10 @@ export function Navbar() {
autoFocus
className="h-9 w-32 md:w-48 px-3 bg-secondary/50 border border-input rounded-none text-sm focus:outline-none focus:ring-1 focus:ring-ring"
/>
<Button type="submit" variant="ghost" size="icon" className="h-9 w-9">
<Button type="submit" variant="ghost" size="icon" className="h-9 w-9" aria-label="Submit search">
<Search className="h-4 w-4" />
</Button>
<Button type="button" variant="ghost" size="icon" className="h-9 w-9" onClick={() => setShowSearch(false)}>
<Button type="button" variant="ghost" size="icon" className="h-9 w-9" onClick={() => setShowSearch(false)} aria-label="Close search">
<X className="h-4 w-4" />
</Button>
</form>
Expand Down