Merged
Conversation
When deleting a pomodoro that was never synced to Google Sheets, the DELETE API returns 404. This should be treated as success since the record doesn't exist anyway. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes sync error when deleting pomodoros that were never synced to Google Sheets.
Problem
When a pomodoro is created locally but never synced (e.g., during 502 errors), deleting it would fail with a 404 error because the record doesn't exist in Google Sheets.
Solution
Treat HTTP 404 on DELETE as success - the record is already gone.
🤖 Generated with Claude Code