coco to fathomnet first draft #34
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30.
Used doctests to test the Examples:
I didn't see any existing tests for the
.scriptsmodule in the test directory, so I didn't create anything there. However, theExamplewould be a good one.Had several failing tests, but these tests fail on a fresh clone as well.
The FAILED test_find method succeeds sometimes and sometimes not, but it doesn't seem to be affected by my changes.
Also, the call to
ObjectDetectionDataset.from_jsonis pretty brittle, as it requires almost all fields that are in the COCO spec. While the spec doesn't explicitly declare certain fields as optional, one may reasonably find examples where, say, aflickr_urlis missing (which COCO-format data providers may find preferable to including a "garbage"flickr_urlwhen one isn't avaialable.). However, this is something that maybe had ought to be brought up in thecoco-librepo.