Closed
Conversation
6 tasks
Owner
|
Thank you @paul1r for the report. Your PR had a CI issues related to statickcheck, which also needed to be upgraded. So I went ahead and created a PR myself that include all version upgrades: #46 I already merged it and released a new version: https://github.com/fatih/faillint/releases/tag/v1.15.0 Let me know if there are still issues with it. |
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to bump our Go version from Go 1.23.x to 1.24.0 has resulted in errors in
faillintAn example error is:
The above was working before bumping the Go version.
What I am proposing is bumping the underlying
golang.org/x/toolsto a more recent version. I did not bump to the latest, as that seems to force a dependence on Go 1.24. Going to 0.29 works on Go 1.22, which is 2 releases old.After doing this and trying it locally, the
faillintchecks seem to pass.