Skip to content

Bump go tools version#45

Closed
paul1r wants to merge 1 commit intofatih:mainfrom
paul1r:paul1r/bump_go_tools_version
Closed

Bump go tools version#45
paul1r wants to merge 1 commit intofatih:mainfrom
paul1r:paul1r/bump_go_tools_version

Conversation

@paul1r
Copy link
Copy Markdown

@paul1r paul1r commented Mar 3, 2025

Trying to bump our Go version from Go 1.23.x to 1.24.0 has resulted in errors in faillint

An example error is:

faillint -paths "sync/atomic=go.uber.org/atomic" ./pkg/scheduler/limits/...
faillint: internal error: package "math" without types was imported from "github.com/grafana/loki/v3/pkg/scheduler/limits"

The above was working before bumping the Go version.

What I am proposing is bumping the underlying golang.org/x/tools to a more recent version. I did not bump to the latest, as that seems to force a dependence on Go 1.24. Going to 0.29 works on Go 1.22, which is 2 releases old.

After doing this and trying it locally, the faillint checks seem to pass.

@fatih
Copy link
Copy Markdown
Owner

fatih commented Mar 5, 2025

Thank you @paul1r for the report. Your PR had a CI issues related to statickcheck, which also needed to be upgraded. So I went ahead and created a PR myself that include all version upgrades: #46 I already merged it and released a new version:

https://github.com/fatih/faillint/releases/tag/v1.15.0

Let me know if there are still issues with it.

@fatih fatih closed this Mar 5, 2025
@paul1r
Copy link
Copy Markdown
Author

paul1r commented Mar 5, 2025

Thank you!

@paul1r paul1r deleted the paul1r/bump_go_tools_version branch March 5, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants