Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7629391cb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if before, ok :=strings.CutSuffix(line, "\\"); ok { | ||
| // If ending with '\', remove '\' and append a space, then continue to read the next line | ||
| fullLineBuilder.WriteString(before) | ||
| fullLineBuilder.WriteString(" ") |
There was a problem hiding this comment.
Backslash-newline continuation in shell removes the newline without adding whitespace, but this code always appends a literal space before reading the next line. For commands that split a token across lines (for example gcc -c src/fo\ then o.c -o foo.o), the merged string becomes src/fo o.c, which changes argument boundaries and makes fileRegex capture the wrong source file, producing an incorrect compile database entry.
Useful? React with 👍 / 👎.
1 participant
No description provided.