Skip to content

Refactor: Implement Strategy pattern for params and study key handling#702

Closed
fderuiter wants to merge 2 commits intomainfrom
refactor/strategy-pattern-params-10998208052101135393
Closed

Refactor: Implement Strategy pattern for params and study key handling#702
fderuiter wants to merge 2 commits intomainfrom
refactor/strategy-pattern-params-10998208052101135393

Conversation

@fderuiter
Copy link
Owner

Refactored ParamMixin and endpoint parameter processing to use the Strategy pattern.

  • Introduced StudyKeyStrategy protocol with implementations: PopStudyKeyStrategy, KeepStudyKeyStrategy, OptionalStudyKeyStrategy.
  • Introduced MappingParamProcessor for declarative parameter mapping.
  • Updated UsersEndpoint and RecordsEndpoint to use new strategies, removing ad-hoc processor classes and boolean flags.
  • Extracted validate_record_entry logic to imednet/validation/cache.py to improve cohesion.
  • Updated StudiesEndpoint to use OptionalStudyKeyStrategy.
  • Updated unit tests to align with new architecture.

PR created automatically by Jules for task 10998208052101135393 started by @fderuiter

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@fderuiter fderuiter closed this Feb 25, 2026
@fderuiter fderuiter deleted the refactor/strategy-pattern-params-10998208052101135393 branch February 27, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant