Refactor ParamMixin to use StudyKeyStrategy#707
Conversation
- Replaced conditional study key logic (`requires_study_key`, `_pop_study_filter`) with a Strategy pattern. - Implemented `KeepStudyKeyStrategy`, `PopStudyKeyStrategy`, and `OptionalStudyKeyStrategy` in `imednet/core/endpoint/strategies.py`. - Updated `ParamMixin` to use `study_key_strategy` property for backward compatibility. - Added comprehensive unit tests for new strategies. - Verified no regressions in existing endpoints. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Replaced conditional study key logic in ParamMixin with a Strategy pattern. - Implemented `KeepStudyKeyStrategy`, `PopStudyKeyStrategy`, and `OptionalStudyKeyStrategy` in `imednet/core/endpoint/strategies.py`. - Updated `ParamMixin` to use `study_key_strategy` property for backward compatibility. - Added comprehensive unit tests in `tests/unit/test_study_key_strategies.py`. - Verified no regressions in existing endpoints. - Fixed code formatting issues in `strategies.py` and test file to pass CI checks. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
fderuiter
deleted the
refactor/param-mixin-study-key-strategy-10105628806116264886
branch
1 participant
Refactored
ParamMixininimednet/core/endpoint/mixins/params.pyto use a Strategy pattern for handling study keys. This eliminates complex boolean flag logic (requires_study_key,_pop_study_filter) and enables better extensibility. The new strategies (KeepStudyKeyStrategy,PopStudyKeyStrategy,OptionalStudyKeyStrategy) are defined inimednet/core/endpoint/strategies.py. Backward compatibility is maintained via a property that maps legacy flags to the appropriate strategy.PR created automatically by Jules for task 10105628806116264886 started by @fderuiter