Skip to content

refactor: cleanup endpoints and mixins (DRY/SOLID)#718

Merged
fderuiter merged 1 commit intomainfrom
architect-refactor-cleanup-8663856002586161599
Feb 27, 2026
Merged

refactor: cleanup endpoints and mixins (DRY/SOLID)#718
fderuiter merged 1 commit intomainfrom
architect-refactor-cleanup-8663856002586161599

Conversation

@fderuiter
Copy link
Owner

This PR implements several architectural cleanups identified during the audit:

  1. Redundancy Removal: The JobsEndpoint had get and async_get methods that merely called super() with the same arguments. These were removed to rely on the parent class implementation, adhering to DRY.
  2. Dead Code Removal: The CreateEndpointMixin (in imednet/core/endpoint/mixins/create.py) was not used by any endpoint (records use RecordCreateOperation) or tests. It has been deleted.
  3. Utility Extraction: The client-side filtering logic in SubjectsEndpoint (comparing IDs as strings) was extracted into a reusable, generic function filter_by_attribute in imednet/utils/filters.py. This improves cohesion and testability.

These changes strictly follow SOLID principles and the "Architect" persona's directives for a modular and clean codebase.


PR created automatically by Jules for task 8663856002586161599 started by @fderuiter

- Remove redundant `get` and `async_get` methods in `JobsEndpoint`.
- Delete unused `CreateEndpointMixin` and its module.
- Extract site filtering logic from `SubjectsEndpoint` to `imednet.utils.filters.filter_by_attribute`.
- Update `SubjectsEndpoint` to use the new utility.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@fderuiter fderuiter marked this pull request as ready for review February 27, 2026 16:41
@fderuiter fderuiter merged commit d0a2459 into main Feb 27, 2026
13 checks passed
@fderuiter fderuiter deleted the architect-refactor-cleanup-8663856002586161599 branch February 27, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant