Reduce redundancy in rulemaking single page document listings#7057
Open
johnnyporkchops wants to merge 3 commits intodevelopfrom
Open
Reduce redundancy in rulemaking single page document listings#7057johnnyporkchops wants to merge 3 commits intodevelopfrom
johnnyporkchops wants to merge 3 commits intodevelopfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7057 +/- ##
===========================================
- Coverage 78.91% 78.82% -0.10%
===========================================
Files 255 255
Lines 6565 6579 +14
===========================================
+ Hits 5181 5186 +5
- Misses 1384 1393 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
patphongs
approved these changes
Mar 26, 2026
Member
patphongs
left a comment
There was a problem hiding this comment.
@johnnyporkchops This looks good, I couldn't find any instances that this did not cover or was incorrect
…st the word Comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary (required)
Resolves Remove duplicate document descriptions in rulemaking template #7041
compare library filter : Compares two strings to determine if they are nearly identical or semantically similar using Python's built in difflib.SequenceMatcher:
similarity_ratio of threshold of .5. Meaning if the description and the label are >= 50% similar, we don't show it.compare_commenter filter : compare the
commenter nametodoc_descriptionwhen one is "lastname, firstname" and the other is "firstname lastname."Avoid repeating
commenter.name | commenter.rolein the entity listing for single commenter comments where it is already shown as the pdf link text above.Required reviewers
one or two devs
Impacted areas of the application
Rulemaking single pages
new filters in filters.py
Screenshots
BEFORE:
### AFTER:
Related PRs
#7054
How to test