Open
Conversation
…res that the git secrets install script can be re-run
danguyf
reviewed
Mar 26, 2026
install-git-secrets-hook.sh
Outdated
Comment on lines
+43
to
+44
| git secrets --add $GLOBAL_TOKEN '(dbpasswd|dbuser|dbname|dbhost|_key|api_key|apikey|password|guid|hostname|pw).*[=:][^(?=|>|.*=>|.*>$)]' | ||
| git secrets --add $GLOBAL_TOKEN '(DBPASSWD|DBUSER|DBNAME|DBHOST|_KEY|API_KEY|APIKEY|PASSWORD|GUID|HOSTNAME|PW).*[=:][^(?=|>|.*=>|.*>$)]' |
Contributor
There was a problem hiding this comment.
Is keeping "api_key"/"API_KEY" redundant now?
Contributor
Author
There was a problem hiding this comment.
Yeah, I thought about removing it, but I didn't. Gonna go back and change that
Removes a redundant token
|
danguyf
approved these changes
Mar 26, 2026
lbeaufort
reviewed
Mar 26, 2026
Member
lbeaufort
left a comment
lbeaufort
left a comment
There was a problem hiding this comment.
This isn't catching CYPRESS_RECORD_KEY="aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee" on my local, but I'm still trying to figure out if the new script installed properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds _key to the list of items that git secrets is flagging, and ensures that the git secrets install script can be re-run
Ticket link: https://fecgov.atlassian.net/browse/FOSEC-99
Git secrets installation instructions: https://github.com/fecgov/fecfile-web-api/wiki/Local-initial-setup#git-secrets