feat: upgrade Lucene dependencies to 9.12.2 and migrate to clojure.test#27
Draft
federkasten wants to merge 4 commits intomasterfrom
Draft
feat: upgrade Lucene dependencies to 9.12.2 and migrate to clojure.test#27federkasten wants to merge 4 commits intomasterfrom
federkasten wants to merge 4 commits intomasterfrom
Conversation
- Update all Lucene dependencies to 9.11.1 - Migrate deprecated APIs to new Lucene 9.x equivalents - Update IndexWriter configuration for new API - Fix compatibility issues with field types and analyzers BREAKING CHANGE: Requires Java 8+ and may have behavior changes due to Lucene version jump Co-authored-by: openhands <openhands@all-hands.dev>
- Remove Midje dependency and lein-midje plugin from project.clj - Convert all test namespaces from midje.sweet to clojure.test - Transform Midje facts/fact syntax to deftest/testing/is structure - Convert tabular tests to doseq loops with test cases - Replace with-state-changes with try/finally blocks for setup/teardown - Fix syntax errors and parentheses matching issues BREAKING CHANGE: Test framework changed from Midje to clojure.test Co-authored-by: openhands <openhands@all-hands.dev>
- Update all Lucene dependencies from 9.11.1 to 9.12.2 (latest 9.x) - Maintain Java 17 compatibility (Lucene 10.x requires Java 21) - Verify basic functionality with core tests Co-authored-by: openhands <openhands@all-hands.dev>
- Remove TODO comments about ngram analyzer compatibility - Uncomment all ngram analyzer test cases - Verify basic ngram functionality works with Lucene 9.x - Some phrase search behavior differences remain due to Lucene 9.x changes Co-authored-by: openhands <openhands@all-hands.dev>
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the Lucene dependencies from 7.5.0 to 9.12.2 (latest 9.x version compatible with Java 17) and migrates the test suite from Midje to clojure.test.
Changes Made
🚀 Lucene Upgrade
🧪 Test Framework Migration
midje.sweet→clojure.testfacts/fact→deftest/testing/isdoseqloops with test caseswith-state-changes→try/finallyblocks🔧 Bug Fixes
Breaking Changes
Testing
Compatibility
Commit History
This PR follows conventional commit format:
feat:for the major Lucene upgraderefactor:for test framework migrationchore:for dependency updatesfix:for resolving TODO commentsNotes
@federkasten can click here to continue refining the PR