feat: RFC9421 #32

AmaseCocoa · 2025-06-20T14:37:17Z

RFC9421準拠の署名実装を追加します。

Add RFC9421 compliant signature implementation.

これは#12 を解決します

github-actions · 2025-06-20T14:37:29Z

Lint Result

Not fixable checks

src/apsig/rfc9421.py:6:42: F401 [*] `cryptography.hazmat.backends.default_backend` imported but unused
  |
4 | from pprint import pprint
5 |
6 | from cryptography.hazmat.backends import default_backend
  |                                          ^^^^^^^^^^^^^^^ F401
7 | from cryptography.hazmat.primitives.asymmetric import ed25519
8 | from cryptography.hazmat.primitives import serialization
  |
  = help: Remove unused import: `cryptography.hazmat.backends.default_backend`

src/apsig/rfc9421.py:8:44: F401 [*] `cryptography.hazmat.primitives.serialization` imported but unused
   |
 6 | from cryptography.hazmat.backends import default_backend
 7 | from cryptography.hazmat.primitives.asymmetric import ed25519
 8 | from cryptography.hazmat.primitives import serialization
   |                                            ^^^^^^^^^^^^^ F401
 9 |
10 | from apsig.draft.tools import calculate_digest
   |
   = help: Remove unused import: `cryptography.hazmat.primitives.serialization`

Found 2 errors.
[*] 2 fixable with the `--fix` option.

github-actions · 2025-07-31T17:11:16Z

Lint Result

Not fixable checks

src/apsig/rfc9421.py:6:42: F401 [*] `cryptography.hazmat.backends.default_backend` imported but unused
  |
4 | from pprint import pprint
5 |
6 | from cryptography.hazmat.backends import default_backend
  |                                          ^^^^^^^^^^^^^^^ F401
7 | from cryptography.hazmat.primitives.asymmetric import ed25519
8 | from cryptography.hazmat.primitives import serialization
  |
  = help: Remove unused import: `cryptography.hazmat.backends.default_backend`

src/apsig/rfc9421.py:8:44: F401 [*] `cryptography.hazmat.primitives.serialization` imported but unused
   |
 6 | from cryptography.hazmat.backends import default_backend
 7 | from cryptography.hazmat.primitives.asymmetric import ed25519
 8 | from cryptography.hazmat.primitives import serialization
   |                                            ^^^^^^^^^^^^^ F401
 9 |
10 | from apsig.draft.tools import calculate_digest
   |
   = help: Remove unused import: `cryptography.hazmat.primitives.serialization`

Found 2 errors.
[*] 2 fixable with the `--fix` option.

AmaseCocoa · 2025-07-31T18:15:39Z

Todo

Fedifyで何故かActorから鍵が読み込まれない
- 生成部分は8b32のテストサーバーと共通なのでRFCの実装側に問題がある可能性あり
~~署名の検証~~

github-actions · 2025-07-31T18:20:03Z

Lint Result

Not fixable checks

src/apsig/rfc9421.py:6:42: F401 [*] `cryptography.hazmat.backends.default_backend` imported but unused
  |
4 | from pprint import pprint
5 |
6 | from cryptography.hazmat.backends import default_backend
  |                                          ^^^^^^^^^^^^^^^ F401
7 | from cryptography.hazmat.primitives.asymmetric import ed25519
8 | from cryptography.hazmat.primitives import serialization
  |
  = help: Remove unused import: `cryptography.hazmat.backends.default_backend`

src/apsig/rfc9421.py:8:44: F401 [*] `cryptography.hazmat.primitives.serialization` imported but unused
   |
 6 | from cryptography.hazmat.backends import default_backend
 7 | from cryptography.hazmat.primitives.asymmetric import ed25519
 8 | from cryptography.hazmat.primitives import serialization
   |                                            ^^^^^^^^^^^^^ F401
 9 |
10 | from apsig.draft.tools import calculate_digest
   |
   = help: Remove unused import: `cryptography.hazmat.primitives.serialization`

Found 2 errors.
[*] 2 fixable with the `--fix` option.

github-actions · 2025-10-20T18:27:10Z

Lint Result

Not fixable checks

F401 [*] `pyfill.datetime.utcnow` imported but unused
  --> src/apsig/rfc9421.py:17:29
   |
15 | )
16 | from multiformats import multibase, multicodec
17 | from pyfill.datetime import utcnow
   |                             ^^^^^^
18 |
19 | from apsig.draft.tools import calculate_digest
   |
help: Remove unused import: `pyfill.datetime.utcnow`

F841 Local variable `gmt_time` is assigned to but never used
   --> src/apsig/rfc9421.py:197:9
    |
195 |             raise ValueError("Unknown created value")
196 |         gmt_tz = pytz.timezone("GMT")
197 |         gmt_time = gmt_tz.localize(created_timestamp)
    |         ^^^^^^^^
198 |         request_time = created_timestamp.astimezone(pytz.utc)
199 |         current_time = dt.datetime.now(dt.UTC)
    |
help: Remove assignment to unused variable `gmt_time`

Found 2 errors.
[*] 1 fixable with the `--fix` option (1 hidden fix can be enabled with the `--unsafe-fixes` option).

github-actions · 2025-10-20T18:57:08Z

Lint Result

Not fixable checks

F841 Local variable `gmt_tz` is assigned to but never used
   --> src/apsig/rfc9421.py:194:9
    |
192 |         else:
193 |             raise ValueError("Unknown created value")
194 |         gmt_tz = pytz.timezone("GMT")
    |         ^^^^^^
195 |         request_time = created_timestamp.astimezone(pytz.utc)
196 |         current_time = dt.datetime.now(dt.UTC)
    |
help: Remove assignment to unused variable `gmt_tz`

Found 1 error.
No fixes available (1 hidden fix can be enabled with the `--unsafe-fixes` option).

github-actions · 2025-10-20T18:58:30Z

Lint Result

Not fixable checks

All checks passed!

This commit overhauls the project's development and build tooling by migrating from PDM to uv and Hatch. Key changes include: - PDM is replaced with uv for dependency management. - Hatch is now the build backend, using setuptools-scm for versioning. - Ruff and Pyrefly are added for linting and static analysis. - The minimum required Python version is lowered to 3.10. - Zed editor settings are added for the new language servers. This also fixes an issue in RFC9421 processing by adding the 'alg' parameter to signatures and properly stripping header whitespace. BREAKING CHANGE: The project no longer uses PDM. Developers must now use uv to install and manage dependencies.

github-actions · 2025-12-28T19:40:46Z

Lint Result

Not fixable checks

N801 Class name `draftSigner` should use CapWords convention
  --> src/apsig/draft/sign.py:14:7
   |
14 | class draftSigner:
   |       ^^^^^^^^^^^
15 |     @staticmethod
16 |     @deprecated(
   |

N801 Class name `draftVerifier` should use CapWords convention
  --> src/apsig/draft/verify.py:18:7
   |
18 | class draftVerifier:
   |       ^^^^^^^^^^^^^
19 |     @staticmethod
20 |     @deprecated(
   |

N818 Exception name `MissingSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:4:7
  |
2 |     pass
3 |
4 | class MissingSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
5 |     pass
  |

N818 Exception name `UnknownSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:7:7
  |
5 |     pass
6 |
7 | class UnknownSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
8 |     pass
  |

N818 Exception name `VerificationFailed` should be named with an Error suffix
  --> src/apsig/exceptions.py:10:7
   |
 8 |     pass
 9 |
10 | class VerificationFailed(SignatureError):
   |       ^^^^^^^^^^^^^^^^^^
11 |     pass
   |

W293 [*] Blank line contains whitespace
  --> src/apsig/ld_signature.py:72:1
   |
70 |         else:
71 |             created_str = created.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z"
72 |         
   | ^^^^^^^^
73 |         default_options: dict[str, str | datetime.datetime] = {
74 |             "@context": "https://w3c-ccg.github.io/security-vocab/contexts/security-v1.jsonld",  # "https://w3id.org/identity/v1"
   |
help: Remove whitespace from blank line

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:10:73
   |
 8 | class ProofSigner:
 9 |     """
10 |     A class for signing documents using the Ed25519 signature algorithm, 
   |                                                                         ^
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
   |
help: Remove trailing whitespace

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:13:61
   |
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
12 |
13 |     This class provides methods to generate keys, sign data, 
   |                                                             ^
14 |     canonicalize documents, and create integrity proofs.
   |
help: Remove trailing whitespace

W293 [*] Blank line contains whitespace
  --> src/apsig/proof/sign.py:84:1
   |
82 |         proof["proofValue"] = multibase.encode(proof_bytes, "base58btc")
83 |         return proof
84 |     
   | ^^^^
85 |     def sign(self, unsecured_document: dict, options: dict):
86 |         """Signs the unsecured document by creating a proof and returning the signed document.
   |
help: Remove whitespace from blank line

Found 9 errors.
[*] 2 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

github-actions · 2025-12-28T19:41:51Z

Lint Result

Not fixable checks

N801 Class name `draftSigner` should use CapWords convention
  --> src/apsig/draft/sign.py:14:7
   |
14 | class draftSigner:
   |       ^^^^^^^^^^^
15 |     @staticmethod
16 |     @deprecated(
   |

N801 Class name `draftVerifier` should use CapWords convention
  --> src/apsig/draft/verify.py:18:7
   |
18 | class draftVerifier:
   |       ^^^^^^^^^^^^^
19 |     @staticmethod
20 |     @deprecated(
   |

N818 Exception name `MissingSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:4:7
  |
2 |     pass
3 |
4 | class MissingSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
5 |     pass
  |

N818 Exception name `UnknownSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:7:7
  |
5 |     pass
6 |
7 | class UnknownSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
8 |     pass
  |

N818 Exception name `VerificationFailed` should be named with an Error suffix
  --> src/apsig/exceptions.py:10:7
   |
 8 |     pass
 9 |
10 | class VerificationFailed(SignatureError):
   |       ^^^^^^^^^^^^^^^^^^
11 |     pass
   |

W293 [*] Blank line contains whitespace
  --> src/apsig/ld_signature.py:72:1
   |
70 |         else:
71 |             created_str = created.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z"
72 |         
   | ^^^^^^^^
73 |         default_options: dict[str, str | datetime.datetime] = {
74 |             "@context": "https://w3c-ccg.github.io/security-vocab/contexts/security-v1.jsonld",  # "https://w3id.org/identity/v1"
   |
help: Remove whitespace from blank line

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:10:73
   |
 8 | class ProofSigner:
 9 |     """
10 |     A class for signing documents using the Ed25519 signature algorithm, 
   |                                                                         ^
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
   |
help: Remove trailing whitespace

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:13:61
   |
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
12 |
13 |     This class provides methods to generate keys, sign data, 
   |                                                             ^
14 |     canonicalize documents, and create integrity proofs.
   |
help: Remove trailing whitespace

W293 [*] Blank line contains whitespace
  --> src/apsig/proof/sign.py:84:1
   |
82 |         proof["proofValue"] = multibase.encode(proof_bytes, "base58btc")
83 |         return proof
84 |     
   | ^^^^
85 |     def sign(self, unsecured_document: dict, options: dict):
86 |         """Signs the unsecured document by creating a proof and returning the signed document.
   |
help: Remove whitespace from blank line

Found 9 errors.
[*] 2 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

github-actions · 2025-12-28T19:45:16Z

Lint Result

Not fixable checks

N801 Class name `draftSigner` should use CapWords convention
  --> src/apsig/draft/sign.py:14:7
   |
14 | class draftSigner:
   |       ^^^^^^^^^^^
15 |     @staticmethod
16 |     @deprecated(
   |

N801 Class name `draftVerifier` should use CapWords convention
  --> src/apsig/draft/verify.py:18:7
   |
18 | class draftVerifier:
   |       ^^^^^^^^^^^^^
19 |     @staticmethod
20 |     @deprecated(
   |

N818 Exception name `MissingSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:4:7
  |
2 |     pass
3 |
4 | class MissingSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
5 |     pass
  |

N818 Exception name `UnknownSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:7:7
  |
5 |     pass
6 |
7 | class UnknownSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
8 |     pass
  |

N818 Exception name `VerificationFailed` should be named with an Error suffix
  --> src/apsig/exceptions.py:10:7
   |
 8 |     pass
 9 |
10 | class VerificationFailed(SignatureError):
   |       ^^^^^^^^^^^^^^^^^^
11 |     pass
   |

W293 [*] Blank line contains whitespace
  --> src/apsig/ld_signature.py:72:1
   |
70 |         else:
71 |             created_str = created.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z"
72 |         
   | ^^^^^^^^
73 |         default_options: dict[str, str | datetime.datetime] = {
74 |             "@context": "https://w3c-ccg.github.io/security-vocab/contexts/security-v1.jsonld",  # "https://w3id.org/identity/v1"
   |
help: Remove whitespace from blank line

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:10:73
   |
 8 | class ProofSigner:
 9 |     """
10 |     A class for signing documents using the Ed25519 signature algorithm, 
   |                                                                         ^
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
   |
help: Remove trailing whitespace

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:13:61
   |
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
12 |
13 |     This class provides methods to generate keys, sign data, 
   |                                                             ^
14 |     canonicalize documents, and create integrity proofs.
   |
help: Remove trailing whitespace

W293 [*] Blank line contains whitespace
  --> src/apsig/proof/sign.py:84:1
   |
82 |         proof["proofValue"] = multibase.encode(proof_bytes, "base58btc")
83 |         return proof
84 |     
   | ^^^^
85 |     def sign(self, unsecured_document: dict, options: dict):
86 |         """Signs the unsecured document by creating a proof and returning the signed document.
   |
help: Remove whitespace from blank line

Found 9 errors.
[*] 2 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

github-actions · 2025-12-28T20:33:37Z

Lint Result

Not fixable checks

N801 Class name `draftSigner` should use CapWords convention
  --> src/apsig/draft/sign.py:14:7
   |
14 | class draftSigner:
   |       ^^^^^^^^^^^
15 |     @staticmethod
16 |     @deprecated(
   |

N801 Class name `draftVerifier` should use CapWords convention
  --> src/apsig/draft/verify.py:18:7
   |
18 | class draftVerifier:
   |       ^^^^^^^^^^^^^
19 |     @staticmethod
20 |     @deprecated(
   |

N818 Exception name `MissingSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:4:7
  |
2 |     pass
3 |
4 | class MissingSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
5 |     pass
  |

N818 Exception name `UnknownSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:7:7
  |
5 |     pass
6 |
7 | class UnknownSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
8 |     pass
  |

N818 Exception name `VerificationFailed` should be named with an Error suffix
  --> src/apsig/exceptions.py:10:7
   |
 8 |     pass
 9 |
10 | class VerificationFailed(SignatureError):
   |       ^^^^^^^^^^^^^^^^^^
11 |     pass
   |

W293 [*] Blank line contains whitespace
  --> src/apsig/ld_signature.py:72:1
   |
70 |         else:
71 |             created_str = created.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z"
72 |         
   | ^^^^^^^^
73 |         default_options: dict[str, str | datetime.datetime] = {
74 |             "@context": "https://w3c-ccg.github.io/security-vocab/contexts/security-v1.jsonld",  # "https://w3id.org/identity/v1"
   |
help: Remove whitespace from blank line

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:10:73
   |
 8 | class ProofSigner:
 9 |     """
10 |     A class for signing documents using the Ed25519 signature algorithm, 
   |                                                                         ^
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
   |
help: Remove trailing whitespace

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:13:61
   |
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
12 |
13 |     This class provides methods to generate keys, sign data, 
   |                                                             ^
14 |     canonicalize documents, and create integrity proofs.
   |
help: Remove trailing whitespace

W293 [*] Blank line contains whitespace
  --> src/apsig/proof/sign.py:84:1
   |
82 |         proof["proofValue"] = multibase.encode(proof_bytes, "base58btc")
83 |         return proof
84 |     
   | ^^^^
85 |     def sign(self, unsecured_document: dict, options: dict):
86 |         """Signs the unsecured document by creating a proof and returning the signed document.
   |
help: Remove whitespace from blank line

Found 9 errors.
[*] 2 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

github-actions · 2025-12-28T20:34:47Z

Lint Result

Not fixable checks

N801 Class name `draftSigner` should use CapWords convention
  --> src/apsig/draft/sign.py:14:7
   |
14 | class draftSigner:
   |       ^^^^^^^^^^^
15 |     @staticmethod
16 |     @deprecated(
   |

N801 Class name `draftVerifier` should use CapWords convention
  --> src/apsig/draft/verify.py:18:7
   |
18 | class draftVerifier:
   |       ^^^^^^^^^^^^^
19 |     @staticmethod
20 |     @deprecated(
   |

N818 Exception name `MissingSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:4:7
  |
2 |     pass
3 |
4 | class MissingSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
5 |     pass
  |

N818 Exception name `UnknownSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:7:7
  |
5 |     pass
6 |
7 | class UnknownSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
8 |     pass
  |

N818 Exception name `VerificationFailed` should be named with an Error suffix
  --> src/apsig/exceptions.py:10:7
   |
 8 |     pass
 9 |
10 | class VerificationFailed(SignatureError):
   |       ^^^^^^^^^^^^^^^^^^
11 |     pass
   |

W293 [*] Blank line contains whitespace
  --> src/apsig/ld_signature.py:72:1
   |
70 |         else:
71 |             created_str = created.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z"
72 |         
   | ^^^^^^^^
73 |         default_options: dict[str, str | datetime.datetime] = {
74 |             "@context": "https://w3c-ccg.github.io/security-vocab/contexts/security-v1.jsonld",  # "https://w3id.org/identity/v1"
   |
help: Remove whitespace from blank line

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:10:73
   |
 8 | class ProofSigner:
 9 |     """
10 |     A class for signing documents using the Ed25519 signature algorithm, 
   |                                                                         ^
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
   |
help: Remove trailing whitespace

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:13:61
   |
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
12 |
13 |     This class provides methods to generate keys, sign data, 
   |                                                             ^
14 |     canonicalize documents, and create integrity proofs.
   |
help: Remove trailing whitespace

W293 [*] Blank line contains whitespace
  --> src/apsig/proof/sign.py:84:1
   |
82 |         proof["proofValue"] = multibase.encode(proof_bytes, "base58btc")
83 |         return proof
84 |     
   | ^^^^
85 |     def sign(self, unsecured_document: dict, options: dict):
86 |         """Signs the unsecured document by creating a proof and returning the signed document.
   |
help: Remove whitespace from blank line

Found 9 errors.
[*] 2 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

github-actions · 2025-12-28T20:35:54Z

Lint Result

Not fixable checks

N801 Class name `draftSigner` should use CapWords convention
  --> src/apsig/draft/sign.py:14:7
   |
14 | class draftSigner:
   |       ^^^^^^^^^^^
15 |     @staticmethod
16 |     @deprecated(
   |

N801 Class name `draftVerifier` should use CapWords convention
  --> src/apsig/draft/verify.py:18:7
   |
18 | class draftVerifier:
   |       ^^^^^^^^^^^^^
19 |     @staticmethod
20 |     @deprecated(
   |

N818 Exception name `MissingSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:4:7
  |
2 |     pass
3 |
4 | class MissingSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
5 |     pass
  |

N818 Exception name `UnknownSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:7:7
  |
5 |     pass
6 |
7 | class UnknownSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
8 |     pass
  |

N818 Exception name `VerificationFailed` should be named with an Error suffix
  --> src/apsig/exceptions.py:10:7
   |
 8 |     pass
 9 |
10 | class VerificationFailed(SignatureError):
   |       ^^^^^^^^^^^^^^^^^^
11 |     pass
   |

W293 [*] Blank line contains whitespace
  --> src/apsig/ld_signature.py:72:1
   |
70 |         else:
71 |             created_str = created.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3] + "Z"
72 |         
   | ^^^^^^^^
73 |         default_options: dict[str, str | datetime.datetime] = {
74 |             "@context": "https://w3c-ccg.github.io/security-vocab/contexts/security-v1.jsonld",  # "https://w3id.org/identity/v1"
   |
help: Remove whitespace from blank line

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:10:73
   |
 8 | class ProofSigner:
 9 |     """
10 |     A class for signing documents using the Ed25519 signature algorithm, 
   |                                                                         ^
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
   |
help: Remove trailing whitespace

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:13:61
   |
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
12 |
13 |     This class provides methods to generate keys, sign data, 
   |                                                             ^
14 |     canonicalize documents, and create integrity proofs.
   |
help: Remove trailing whitespace

W293 [*] Blank line contains whitespace
  --> src/apsig/proof/sign.py:84:1
   |
82 |         proof["proofValue"] = multibase.encode(proof_bytes, "base58btc")
83 |         return proof
84 |     
   | ^^^^
85 |     def sign(self, unsecured_document: dict, options: dict):
86 |         """Signs the unsecured document by creating a proof and returning the signed document.
   |
help: Remove whitespace from blank line

Found 9 errors.
[*] 2 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

codecov · 2025-12-28T20:36:13Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

github-actions · 2025-12-28T20:38:51Z

Lint Result

Not fixable checks

N801 Class name `draftSigner` should use CapWords convention
  --> src/apsig/draft/sign.py:14:7
   |
14 | class draftSigner:
   |       ^^^^^^^^^^^
15 |     @staticmethod
16 |     @deprecated(
   |

N801 Class name `draftVerifier` should use CapWords convention
  --> src/apsig/draft/verify.py:18:7
   |
18 | class draftVerifier:
   |       ^^^^^^^^^^^^^
19 |     @staticmethod
20 |     @deprecated(
   |

N818 Exception name `MissingSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:4:7
  |
2 |     pass
3 |
4 | class MissingSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
5 |     pass
  |

N818 Exception name `UnknownSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:7:7
  |
5 |     pass
6 |
7 | class UnknownSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
8 |     pass
  |

N818 Exception name `VerificationFailed` should be named with an Error suffix
  --> src/apsig/exceptions.py:10:7
   |
 8 |     pass
 9 |
10 | class VerificationFailed(SignatureError):
   |       ^^^^^^^^^^^^^^^^^^
11 |     pass
   |

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:10:73
   |
 8 | class ProofSigner:
 9 |     """
10 |     A class for signing documents using the Ed25519 signature algorithm, 
   |                                                                         ^
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
   |
help: Remove trailing whitespace

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:13:61
   |
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
12 |
13 |     This class provides methods to generate keys, sign data, 
   |                                                             ^
14 |     canonicalize documents, and create integrity proofs.
   |
help: Remove trailing whitespace

W293 [*] Blank line contains whitespace
  --> src/apsig/proof/sign.py:84:1
   |
82 |         proof["proofValue"] = multibase.encode(proof_bytes, "base58btc")
83 |         return proof
84 |     
   | ^^^^
85 |     def sign(self, unsecured_document: dict, options: dict):
86 |         """Signs the unsecured document by creating a proof and returning the signed document.
   |
help: Remove whitespace from blank line

Found 8 errors.
[*] 1 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

github-actions · 2025-12-28T20:40:36Z

Lint Result

Not fixable checks

N801 Class name `draftSigner` should use CapWords convention
  --> src/apsig/draft/sign.py:14:7
   |
14 | class draftSigner:
   |       ^^^^^^^^^^^
15 |     @staticmethod
16 |     @deprecated(
   |

N801 Class name `draftVerifier` should use CapWords convention
  --> src/apsig/draft/verify.py:18:7
   |
18 | class draftVerifier:
   |       ^^^^^^^^^^^^^
19 |     @staticmethod
20 |     @deprecated(
   |

N818 Exception name `MissingSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:4:7
  |
2 |     pass
3 |
4 | class MissingSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
5 |     pass
  |

N818 Exception name `UnknownSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:7:7
  |
5 |     pass
6 |
7 | class UnknownSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
8 |     pass
  |

N818 Exception name `VerificationFailed` should be named with an Error suffix
  --> src/apsig/exceptions.py:10:7
   |
 8 |     pass
 9 |
10 | class VerificationFailed(SignatureError):
   |       ^^^^^^^^^^^^^^^^^^
11 |     pass
   |

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:10:73
   |
 8 | class ProofSigner:
 9 |     """
10 |     A class for signing documents using the Ed25519 signature algorithm, 
   |                                                                         ^
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
   |
help: Remove trailing whitespace

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:13:61
   |
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
12 |
13 |     This class provides methods to generate keys, sign data, 
   |                                                             ^
14 |     canonicalize documents, and create integrity proofs.
   |
help: Remove trailing whitespace

W293 [*] Blank line contains whitespace
  --> src/apsig/proof/sign.py:84:1
   |
82 |         proof["proofValue"] = multibase.encode(proof_bytes, "base58btc")
83 |         return proof
84 |     
   | ^^^^
85 |     def sign(self, unsecured_document: dict, options: dict):
86 |         """Signs the unsecured document by creating a proof and returning the signed document.
   |
help: Remove whitespace from blank line

Found 8 errors.
[*] 1 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

github-actions · 2025-12-28T20:45:47Z

Lint Result

Not fixable checks

N801 Class name `draftSigner` should use CapWords convention
  --> src/apsig/draft/sign.py:14:7
   |
14 | class draftSigner:
   |       ^^^^^^^^^^^
15 |     @staticmethod
16 |     @deprecated(
   |

N801 Class name `draftVerifier` should use CapWords convention
  --> src/apsig/draft/verify.py:18:7
   |
18 | class draftVerifier:
   |       ^^^^^^^^^^^^^
19 |     @staticmethod
20 |     @deprecated(
   |

N818 Exception name `MissingSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:4:7
  |
2 |     pass
3 |
4 | class MissingSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
5 |     pass
  |

N818 Exception name `UnknownSignature` should be named with an Error suffix
 --> src/apsig/exceptions.py:7:7
  |
5 |     pass
6 |
7 | class UnknownSignature(SignatureError):
  |       ^^^^^^^^^^^^^^^^
8 |     pass
  |

N818 Exception name `VerificationFailed` should be named with an Error suffix
  --> src/apsig/exceptions.py:10:7
   |
 8 |     pass
 9 |
10 | class VerificationFailed(SignatureError):
   |       ^^^^^^^^^^^^^^^^^^
11 |     pass
   |

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:10:73
   |
 8 | class ProofSigner:
 9 |     """
10 |     A class for signing documents using the Ed25519 signature algorithm, 
   |                                                                         ^
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
   |
help: Remove trailing whitespace

W291 Trailing whitespace
  --> src/apsig/proof/sign.py:13:61
   |
11 |     implementing Object Integrity Proofs as specified in FEP-8b32.
12 |
13 |     This class provides methods to generate keys, sign data, 
   |                                                             ^
14 |     canonicalize documents, and create integrity proofs.
   |
help: Remove trailing whitespace

W293 [*] Blank line contains whitespace
  --> src/apsig/proof/sign.py:84:1
   |
82 |         proof["proofValue"] = multibase.encode(proof_bytes, "base58btc")
83 |         return proof
84 |     
   | ^^^^
85 |     def sign(self, unsecured_document: dict, options: dict):
86 |         """Signs the unsecured document by creating a proof and returning the signed document.
   |
help: Remove whitespace from blank line

Found 8 errors.
[*] 1 fixable with the `--fix` option (2 hidden fixes can be enabled with the `--unsafe-fixes` option).

AmaseCocoa · 2025-12-28T20:48:13Z

/gemini summary

AmaseCocoa · 2025-12-28T20:48:23Z

/gemini review

gemini-code-assist · 2025-12-28T20:48:43Z

Summary of Changes

This pull request significantly expands the library's cryptographic capabilities by integrating RFC9421 compliant HTTP message signatures, enabling robust signing and verification of web requests. Concurrently, it modernizes the development workflow through a comprehensive migration to pytest for testing and the adoption of advanced linting and formatting tools. These changes, coupled with dependency updates and codebase cleanup, aim to enhance security, improve developer efficiency, and ensure compatibility with newer Python versions.

Highlights

New RFC9421 HTTP Message Signatures: Introduced RFC9421Signer and RFC9421Verifier classes in a new module src/apsig/rfc9421.py to support RFC9421 compliant HTTP message signing and verification.
Testing Framework Migration: Migrated unit tests from unittest to pytest across several test files, including test_draft.py, test_ld.py, test_multibase_ed25519.py, and test_proof.py, and updated Taskfile.yaml accordingly.
Development Tooling Enhancements: Added Zed editor settings (.zed/settings.json) and comprehensive ruff and pyrefly configurations in pyproject.toml to improve linting, formatting, and overall developer experience.
Dependency and Python Version Updates: Added http-sf and authlib dependencies, removed pyfill, dropped support for Python 3.9, and added support for Python 3.14 in pyproject.toml.
Codebase Cleanup: Removed several end-to-end test server files (dev/e2e/faker/actor.py, dev/e2e/server_ld.py, dev/e2e/server_proof.py) and a datetime polyfill (src/apsig/__polyfill/datetime.py), streamlining the project structure.

Changelog

.zed/settings.json
- Added Zed editor configuration for Python language servers (ruff, pyrefly) to enhance code editing and analysis.
Taskfile.yaml
- Updated the test command to utilize pytest for running tests, replacing the previous unittest command.
dev/e2e/faker/actor.py
- Removed, streamlining the end-to-end testing setup.
dev/e2e/server_ld.py
- Removed, streamlining the end-to-end testing setup.
dev/e2e/server_proof.py
- Removed, streamlining the end-to-end testing setup.
pyproject.toml
- Added http-sf and authlib to the project dependencies.
- Removed pyfill from dependencies.
- Updated Python classifiers to remove 3.9 and include 3.14.
- Introduced detailed ruff and pyrefly configurations for code quality enforcement.
- Refactored [dependency-groups] to categorize development dependencies.
- Removed the [tool.pdm.version] section.
src/apsig/__polyfill/datetime.py
- Removed, as direct datetime.datetime.now(datetime.timezone.utc) usage is now preferred.
src/apsig/_version.py
- Version string updated to 0.5.4.post1.dev34+g449058cc7.d20251228.
src/apsig/draft/sign.py
- Applied minor code style and type hinting improvements.
src/apsig/draft/verify.py
- Applied minor code style and type hinting improvements, and updated datetime usage for consistency.
src/apsig/ld_signature.py
- Made minor code style and type hinting adjustments, removed utcnow import, and added a type check for jsonld.normalize output.
src/apsig/proof/verify.py
- Applied minor code style and type hinting improvements.
src/apsig/rfc9421.py
- Added a new file containing RFC9421Signer and RFC9421Verifier classes for HTTP message signature implementation.
src/apsig/tools.py
- Applied minor code style adjustments.
tests/test_draft.py
- Converted from unittest to pytest framework, utilizing fixtures.
tests/test_ld.py
- Converted from unittest to pytest framework, utilizing fixtures.
tests/test_multibase_ed25519.py
- Converted from unittest to pytest framework, utilizing fixtures.
tests/test_proof.py
- Converted from unittest to pytest framework, utilizing fixtures.
tests/test_rfc9421.py
- Added new test file specifically for the RFC9421 implementation.

Ignored Files

Ignored by pattern: .github/workflows/** (1)
- .github/workflows/test.yml

Activity

Linting reports from github-actions[bot] consistently highlighted issues such as unused imports (F401), incorrect class naming conventions (N801), missing exception suffixes (N818), and trailing whitespace (W291, W293).
The author, AmaseCocoa, noted a "Todo" item, indicating an ongoing task to investigate why keys are not being loaded from Actor in Fedify, suggesting a potential issue with the RFC implementation, and also mentioned "署名の検証" (signature verification) as a task.
Codecov bot initiated coverage reporting for the pull request.

gemini-code-assist

Code Review

このプルリクエストは、RFC9421準拠の署名実装を追加するもので、素晴らしい機能追加です。また、テストをunittestからpytestに移行し、依存関係やコードフォーマットを整理することで、プロジェクトの保守性も向上しています。新しいRFC9421の実装は、複数のアルゴリズムをサポートしており包括的です。レビューを通して、新しい実装にデッドコード、パラメータ処理のバグ、署名抽出ロジックの分かりにくさなど、いくつかの改善点を見つけました。これらの点を修正することで、実装がより堅牢になるでしょう。

src/apsig/rfc9421.py

Removes incorrect processing of '@signature-params' header. Ensures 'key_id' conversion to string after null check for robustness.

for more information, see https://pre-commit.ci

AmaseCocoa self-assigned this Jun 20, 2025

AmaseCocoa added the enhancement New feature or request label Jun 20, 2025

AmaseCocoa linked an issue Jun 20, 2025 that may be closed by this pull request

Implementing RFC 9421 #12

Closed

chore

1b025b0

wip

6dd0920

AmaseCocoa added 5 commits October 21, 2025 01:07

Merge branch 'main' into rfc9421

d5780a0

refactor: refactor some codes

59e0f9c

BREAKING CHANGE: require python 3.11 after

a93a7f7

feat: first-version of rfc9421 implemention

d2c1630

chore: update lockfile

807866c

AmaseCocoa added 2 commits October 21, 2025 03:56

fix(ld): incorrect type hints

8da7903

refactor: remove debugging codes

7408a09

refactor(rfc9421): remove unused variable

f62c701

AmaseCocoa mentioned this pull request Oct 21, 2025

v1.0.0 fedi-libs/apkit#33

Open

8 tasks

AmaseCocoa added 3 commits December 28, 2025 02:27

feat: Support for more algorithms

263d9f8

Merge branch 'main' into rfc9421

4a07ba1

fix: update lockfile

6029b58

AmaseCocoa added 2 commits December 29, 2025 04:44

chore: delete e2e codes

9b4c373

fix(test): fix tests

3c16994

fix(ci): fix test ci

c0d792a

fix(ci): fix target branch to test

8f99395

fix(ci): add pytest-cov to deps

449058c

fix: remove polyfill

a62597c

fix: use dt.timezone.utc

1727b8b

AmaseCocoa added 3 commits December 29, 2025 05:42

fix(rfc9421): add ecdsa in alg list

f8c6c6a

refactor(rfc9421): merge case of "p256-pub" and "p384-pub"

165c3fe

refactor: remove type hints

cf3fdfe

AmaseCocoa marked this pull request as ready for review December 28, 2025 20:47

chore: remove lint ci (merged to pre-commit.ci)

d9d4107

gemini-code-assist bot reviewed Dec 28, 2025

View reviewed changes

src/apsig/rfc9421.py Outdated Show resolved Hide resolved

src/apsig/rfc9421.py Outdated Show resolved Hide resolved

src/apsig/rfc9421.py Show resolved Hide resolved

AmaseCocoa and others added 8 commits December 29, 2025 05:57

fix(rfc9421): Adjust signature parameter handling

a7986d5

Removes incorrect processing of '@signature-params' header. Ensures 'key_id' conversion to string after null check for robustness.

feat: pre-commit.ci

e22371d

chore: update tool versions

f47adb3

fix: exclude ruff and pyrefly

ee0ae8b

[pre-commit.ci] auto fixes from pre-commit.com hooks

ae2ed30

for more information, see https://pre-commit.ci

fix: fix lint errors

170ac82

chore: temporary ignore pyrefly checker

045ffc9

[pre-commit.ci] auto fixes from pre-commit.com hooks

32ad259

for more information, see https://pre-commit.ci

AmaseCocoa merged commit 875e765 into main Dec 28, 2025
10 checks passed

feat: RFC9421 #32

feat: RFC9421 #32

Uh oh!

Conversation

AmaseCocoa commented Jun 20, 2025

Uh oh!

github-actions bot commented Jun 20, 2025

Lint Result

Uh oh!

github-actions bot commented Jul 31, 2025

Lint Result

Uh oh!

AmaseCocoa commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 31, 2025

Lint Result

Uh oh!

github-actions bot commented Oct 20, 2025

Lint Result

Uh oh!

github-actions bot commented Oct 20, 2025

Lint Result

Uh oh!

github-actions bot commented Oct 20, 2025

Lint Result

Uh oh!

github-actions bot commented Dec 28, 2025

Lint Result

Uh oh!

github-actions bot commented Dec 28, 2025

Lint Result

Uh oh!

github-actions bot commented Dec 28, 2025

Lint Result

Uh oh!

github-actions bot commented Dec 28, 2025

Lint Result

Uh oh!

github-actions bot commented Dec 28, 2025

Lint Result

Uh oh!

github-actions bot commented Dec 28, 2025

Lint Result

Uh oh!

codecov bot commented Dec 28, 2025

Welcome to Codecov 🎉

Uh oh!

github-actions bot commented Dec 28, 2025

Lint Result

Uh oh!

github-actions bot commented Dec 28, 2025

Lint Result

Uh oh!

github-actions bot commented Dec 28, 2025

Lint Result

Uh oh!

AmaseCocoa commented Dec 28, 2025

Uh oh!

AmaseCocoa commented Dec 28, 2025

Uh oh!

gemini-code-assist bot commented Dec 28, 2025

Summary of Changes

Highlights

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

AmaseCocoa commented Jul 31, 2025 •

edited

Loading