feat: added a specific message depending on failure type#389
Draft
kevkevinpal wants to merge 1 commit intofedimint:masterfrom
Draft
feat: added a specific message depending on failure type#389kevkevinpal wants to merge 1 commit intofedimint:masterfrom
kevkevinpal wants to merge 1 commit intofedimint:masterfrom
Conversation
Author
|
When testing on an expired invoice I get a parsing error. What would make more sense to me is to show the user that the invoice is expired instead of either not showing anything in the UI or saying parsing error when scanned |
Collaborator
|
Screenshot looks great. This is definitely an issue in the app right now. I'm not sure thrilled about string matching to determine the error though, as that is kind of brittle. But right now that's all we can probably do since I don't know if we have any better way of propagating errors from rust -> flutter. Would you be interested in researching how to propagate errors properly from rust -> flutter? I suspect there's a lot more places in the code that would benefit from this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
This is just an idea of what we can do (setting as draft for now to get wording correct)
Closes #388
Example message
