Skip to content

feat: added a specific message depending on failure type#389

Draft
kevkevinpal wants to merge 1 commit intofedimint:masterfrom
kevkevinpal:failureToSendMessage
Draft

feat: added a specific message depending on failure type#389
kevkevinpal wants to merge 1 commit intofedimint:masterfrom
kevkevinpal:failureToSendMessage

Conversation

@kevkevinpal
Copy link
Copy Markdown

@kevkevinpal kevkevinpal commented Mar 10, 2026

summary

This is just an idea of what we can do (setting as draft for now to get wording correct)

Closes #388


Example message
Screenshot 2026-03-10 at 12 44 01 PM

@kevkevinpal
Copy link
Copy Markdown
Author

When testing on an expired invoice I get a parsing error.

What would make more sense to me is to show the user that the invoice is expired instead of either not showing anything in the UI or saying parsing error when scanned

@m1sterc001guy
Copy link
Copy Markdown
Collaborator

Screenshot looks great. This is definitely an issue in the app right now. I'm not sure thrilled about string matching to determine the error though, as that is kind of brittle. But right now that's all we can probably do since I don't know if we have any better way of propagating errors from rust -> flutter.

Would you be interested in researching how to propagate errors properly from rust -> flutter? I suspect there's a lot more places in the code that would benefit from this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should show insufficent balance when trying to pay too large of an invoice

2 participants