Use quotes for local project header includes #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace angle brackets <...> with quotes "..." for project headers to improve compatibility with IDEs and tooling. While both forms are valid, many tools and IDEs treat quoted includes as local files, enabling better indexing, navigation, and refactoring support.
Follow up to switching from angle brackets to quoted includes for local headers. Since headers are now included with "..." and reside in the same or subdirectories, the -Isrc include path is no longer necessary.
Member
|
For simple projects like this it of course works. I first noticed that the OpenJDK's codebase uses this style and I started to like it. |
Member
Author
|
Is there anything else expected from me in this PR so that it can be accepted? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace angle brackets <...> with quotes "..." for project headers to improve compatibility with IDEs and tooling.
While both forms are valid, many tools and IDEs treat quoted includes as local files, enabling better indexing, navigation, and refactoring support.
Since headers are now included with "..." and reside in the same or subdirectories, the -Isrc include path is no longer necessary.