Guess the right template from /etc/os-release#108
Open
dcermak wants to merge 4 commits intofedora-ruby:masterfrom
Open
Guess the right template from /etc/os-release#108dcermak wants to merge 4 commits intofedora-ruby:masterfrom
dcermak wants to merge 4 commits intofedora-ruby:masterfrom
Conversation
ekohl
reviewed
Jul 5, 2022
1595078 to
4530ef8
Compare
Contributor
|
#112 was merged. Would you mind rebasing? |
Member
|
Not objecting the intent of this PR, but I'd be a bit happier, if the functionality lived somewhere outside of the executable. This way, it would be better testable. Of course if there was test case attached, it would be even better. |
4530ef8 to
e6acc87
Compare
(cherry picked from commit 91bc63e) Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl> Co-authored-by: Dan Čermák <dcermak@suse.com>
…ontains ID="opensuse-tumbleweed" (cherry picked from commit 7fa4f56)
At the moment you have to manually specify the template file name on Leap, as gem2rpm tries to use the opensuse-leap template on Leap, which does not exist. Therefore we fallback to the opensuse template instead. (cherry picked from commit 2f34876)
e6acc87 to
e23d592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few patches from openSUSE's fork to support guessing the correct template from
/etc/os-release