treewide: refactor and clean up various components and utils#145
Open
treewide: refactor and clean up various components and utils#145
Conversation
Not harmful to be really honest, but eh. Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: If5c53c448174e96950085db355c6a1d06a6a6964
…nals Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I686db149fc1cb48e0ac72dd3d04a37e06a6a6964
Introduces `type_is`, `last_type_segment`, and `first_type_arg` helpers that inspect the `syn` type tree directly and removes the fragile `to_token_stream()` string comparisons that I always hated. Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I7bfadff11b808ce4b46decf07ad7e0ea6a6a6964
Moves `extract_page_title` helper to `ndg-utils::markdown`, and removes the local copy from `ndg-html`. `collect_included_files` is now superseded by `process_markdown_files` populating `config.included_files` as a side-effect, so it's removed entirely. Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I66eb51184c4dd264e5b74cb3d8063b306a6a6964
…issues Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Ib532f0768cd6dd28866196fc809f5b316a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I6768c5531746b4fe89a04e8033ef115a6a6a6964
…variant `preceding_doc_comment` now returns early instead of found `Option<String>` accumulator. Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I097657418769874a5c40e511aae9f3b76a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I735326e305656d38023e03d86938623e6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I6723d68a71e2df2bc023ee45c5d01bde6a6a6964
…ailure Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I5d3a63ef92d16e33dc61d34a158a49ac6a6a6964
…formatting Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I7e4f1328ae3ce7ea8414472db6a649b56a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I41bbede677512d74b556baa4c6db3fc46a6a6964
…r guards Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I4ef4f4d17e999d8e6b90de015d8b83a46a6a6964
Always cleaner this way. Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I26280424e3b9ae3b5214505d2792f8166a6a6964
template tests in template tests Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I404147f527b75b4dce0afaf5c0db348a6a6a6964
NotAShelf
force-pushed
the
notashelf/push-swuwxtlwzutu
branch
from
86a0454 to
ef2367e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.