Open
Conversation
added 2 commits
January 30, 2021 21:39
added 2 commits
January 30, 2021 22:19
|
Does it waiting for ending of discussion here felangel/bloc#2526? |
|
Seems like it's time to revisit PR, @felangel ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
useBlocBuilder hook. This is essentially a straight copy over of the BlocBuilder code but turned into a hook. The only differences between the two are:
mountedvariable for theuseEffectso that subscribe is only called once on loadnullinstead ofthisstateandsinstead ofpreviousandcurrent. I found that the rebuild was always one state cycle behind so I made this changeif (bloc !== thisBloc.current)check. I found that adding this check breaks the codepreviousStateand I do not callsetState. Doing so broke the code.I tested it pretty rigorously with
condition, as well as yielding several states during one action - I think it should work well. Please let me know what you think!Type of Change