feat: Includes the ability to create a custom Cubit by extending Cubit class#92
Open
MattiaPispisa wants to merge 1 commit intofelangel:masterfrom
Open
feat: Includes the ability to create a custom Cubit by extending Cubit class#92MattiaPispisa wants to merge 1 commit intofelangel:masterfrom
MattiaPispisa wants to merge 1 commit intofelangel:masterfrom
Conversation
felangel
reviewed
Oct 25, 2022
| super() | ||
| this.stateSubject = new Subject() | ||
| export abstract class Bloc<Event, State> extends BlocBase<State> { | ||
| /* istanbul ignore next */ |
Owner
There was a problem hiding this comment.
Suggested change
| /* istanbul ignore next */ |
Why are we ignoring this line?
Author
There was a problem hiding this comment.
Just a problem with jest.
Babel converts the super to var _this = _super.call (this) || this and this will result in never testing the second condition (the test coverage will not be 100%).
I think updating the dependencies solves the problem but I preferred to not change the dependencies.
MattiaPispisa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
APIs to create cubit by extending the cubit class.
Cubit and Bloc extends a common class: BlocBase
Type of Change