Conversation
thwllms
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has been created
A JSON-based workflow abstraction layer that compiles to Argo Workflows
cat workflow.json | docker run -i workflow-compiler > output.yamlCurrent Issues and Limitaitons
The images (hms-golang, ras_v660, ffrd_base) are not in a container registry. This is becoming more of a blocker for development since I'm struggling getting argo to work with local container and I'm not sure it is possible or really designed for that anyway? It would be very helpful to have these images build and pull-able from a registry going forward.
There is limitation in the schemas where we cannot specify where we want the inputs downloaded to when we use and
s3_storetype store, this is an issue since we'll need to copy (and replace?) some RAS model files with results from the HMS container (excess precip HDF file) and we need to know where this file needs to go in relation to the model files. For now I've used theffrd_baseimage to download to a shared mount and used that as the store for the RAS file inputs. It's a bit hacky but if we move forward with that we should probably develop a reference container and schemas for uploading and downloading files.Questions for review
(Download model files -> modify those files -> run the simulation)
in addition to:
(Download model files -> run the simulation )
a. What container registry should we use?
b. If we use GHCR, should we make separate repositories and packages for each container?
c. Is any CI/CD needed or would manual publishing work?
envobject in the json schema to support passing env vars to individual tasks, but hard coding access keys into these sort of makes them hard to source control. In production environments they may not be needed at all if EC2 instance credentials are used correctly and all buckets are accessible from the same account (cross account access is possible through bucket policies).