Skip to content

Feature/stormlit lakehouse#124

Merged
zherbz merged 25 commits intomainfrom
feature/stormlit-lakehouse
Mar 25, 2026
Merged

Feature/stormlit lakehouse#124
zherbz merged 25 commits intomainfrom
feature/stormlit-lakehouse

Conversation

@zherbz
Copy link
Copy Markdown
Collaborator

@zherbz zherbz commented Feb 27, 2026

This addresses the 'Make Stormlit Truly Multi-Project' issue: #118

Edits are specific to the meteorology page.

  • Tabular Data (storm catalog): loaded from postgres using iceberg metadata
  • Raster Data (AORC): loaded using icechunk repo

Added iceberg etl scipts in etl/lakehouse

@github-actions
Copy link
Copy Markdown

🔍 SonarQube Analysis Results

Summary:

  • 🐛 Bugs: 1
  • 🔒 Vulnerabilities: 2
  • 🧹 Code Smells: 81
  • 📊 Total Issues: 84

📋 Detailed Reports Available

📥 Download Full Report - Click "Artifacts" section

The detailed report includes:

  • Complete breakdown by severity and type
  • Specific file locations and line numbers
  • Rule descriptions and fix suggestions
  • CSV format for spreadsheet analysis
  • Raw JSON data for custom processing

💡 Review the workflow summary for metrics and download the artifact for complete details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 27, 2026

🔍 Vulnerabilities of ghcr.io/fema-ffrd/stormlit:pr-124

📦 Image Reference ghcr.io/fema-ffrd/stormlit:pr-124
digestsha256:f5aaad735258b421cfca364564ad5f2fffe929f4f5d278f395ff82f1ddf70180
vulnerabilitiescritical: 0 high: 0 medium: 0 low: 0
platformlinux/amd64
size1.0 GB
packages532
📦 Base Image ubuntu:24.04
also known as
  • latest
  • noble
  • noble-20260217
digestsha256:67efaecc0031a612cf7bb3c863407018dbbef0a971f62032b77aa542ac8ac0d2
vulnerabilitiescritical: 0 high: 0 medium: 4 low: 4

@github-actions
Copy link
Copy Markdown

🔍 SonarQube Analysis Results

Summary:

  • 🐛 Bugs: 1
  • 🔒 Vulnerabilities: 2
  • 🧹 Code Smells: 81
  • 📊 Total Issues: 84

📋 Detailed Reports Available

📥 Download Full Report - Click "Artifacts" section

The detailed report includes:

  • Complete breakdown by severity and type
  • Specific file locations and line numbers
  • Rule descriptions and fix suggestions
  • CSV format for spreadsheet analysis
  • Raw JSON data for custom processing

💡 Review the workflow summary for metrics and download the artifact for complete details.

@github-actions
Copy link
Copy Markdown

🔍 SonarQube Analysis Results

Summary:

  • 🐛 Bugs: 1
  • 🔒 Vulnerabilities: 2
  • 🧹 Code Smells: 81
  • 📊 Total Issues: 84

📋 Detailed Reports Available

📥 Download Full Report - Click "Artifacts" section

The detailed report includes:

  • Complete breakdown by severity and type
  • Specific file locations and line numbers
  • Rule descriptions and fix suggestions
  • CSV format for spreadsheet analysis
  • Raw JSON data for custom processing

💡 Review the workflow summary for metrics and download the artifact for complete details.

@zherbz zherbz requested review from ngoXminh and thwllms February 27, 2026 23:01
@github-actions
Copy link
Copy Markdown

🔍 SonarQube Analysis Results

Summary:

  • 🐛 Bugs: 1
  • 🔒 Vulnerabilities: 2
  • 🧹 Code Smells: 84
  • 📊 Total Issues: 87

📋 Detailed Reports Available

📥 Download Full Report - Click "Artifacts" section

The detailed report includes:

  • Complete breakdown by severity and type
  • Specific file locations and line numbers
  • Rule descriptions and fix suggestions
  • CSV format for spreadsheet analysis
  • Raw JSON data for custom processing

💡 Review the workflow summary for metrics and download the artifact for complete details.

@github-actions
Copy link
Copy Markdown

🔍 SonarQube Analysis Results

Summary:

  • 🐛 Bugs: 1
  • 🔒 Vulnerabilities: 2
  • 🧹 Code Smells: 89
  • 📊 Total Issues: 92

📋 Detailed Reports Available

📥 Download Full Report - Click "Artifacts" section

The detailed report includes:

  • Complete breakdown by severity and type
  • Specific file locations and line numbers
  • Rule descriptions and fix suggestions
  • CSV format for spreadsheet analysis
  • Raw JSON data for custom processing

💡 Review the workflow summary for metrics and download the artifact for complete details.

@github-actions
Copy link
Copy Markdown

🔍 SonarQube Analysis Results

Summary:

  • 🐛 Bugs: 1
  • 🔒 Vulnerabilities: 2
  • 🧹 Code Smells: 89
  • 📊 Total Issues: 92

📋 Detailed Reports Available

📥 Download Full Report - Click "Artifacts" section

The detailed report includes:

  • Complete breakdown by severity and type
  • Specific file locations and line numbers
  • Rule descriptions and fix suggestions
  • CSV format for spreadsheet analysis
  • Raw JSON data for custom processing

💡 Review the workflow summary for metrics and download the artifact for complete details.

@github-actions
Copy link
Copy Markdown

🔍 SonarQube Analysis Results

Summary:

  • 🐛 Bugs: 1
  • 🔒 Vulnerabilities: 2
  • 🧹 Code Smells: 89
  • 📊 Total Issues: 92

📋 Detailed Reports Available

📥 Download Full Report - Click "Artifacts" section

The detailed report includes:

  • Complete breakdown by severity and type
  • Specific file locations and line numbers
  • Rule descriptions and fix suggestions
  • CSV format for spreadsheet analysis
  • Raw JSON data for custom processing

💡 Review the workflow summary for metrics and download the artifact for complete details.

Copy link
Copy Markdown
Contributor

@thwllms thwllms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zherbz looking good overall. Notes:

  1. rioxarray needs to be added as as a dependency in env.yml and imported at the top of icechunk.py, probably with a # noqa comment to avoid getting flagged as an unused import.
import rioxarray  # noqa: F401 - needed to ensure rioxarray is registered with xarray
  1. tornado dependency needs to be upgraded to address the Docker Scout vulnerability finding.
  2. Other review comments are optional suggestions.

Comment thread app/src/utils/storms.py
Comment thread app/src/db/query_meta_tables.py
Comment thread app/.env.template Outdated
Comment thread etl/lakehouse/load_stac_geoparquet.py Outdated
Comment thread etl/lakehouse/configs/datalake.config.json Outdated
Comment thread etl/lakehouse/load_geojson_to_iceberg.py Outdated
@github-actions
Copy link
Copy Markdown

🔍 SonarQube Analysis Results

Summary:

  • 🐛 Bugs: 1
  • 🔒 Vulnerabilities: 2
  • 🧹 Code Smells: 89
  • 📊 Total Issues: 92

📋 Detailed Reports Available

📥 Download Full Report - Click "Artifacts" section

The detailed report includes:

  • Complete breakdown by severity and type
  • Specific file locations and line numbers
  • Rule descriptions and fix suggestions
  • CSV format for spreadsheet analysis
  • Raw JSON data for custom processing

💡 Review the workflow summary for metrics and download the artifact for complete details.

@github-actions
Copy link
Copy Markdown

🔍 SonarQube Analysis Results

Summary:

  • 🐛 Bugs: 1
  • 🔒 Vulnerabilities: 2
  • 🧹 Code Smells: 89
  • 📊 Total Issues: 92

📋 Detailed Reports Available

📥 Download Full Report - Click "Artifacts" section

The detailed report includes:

  • Complete breakdown by severity and type
  • Specific file locations and line numbers
  • Rule descriptions and fix suggestions
  • CSV format for spreadsheet analysis
  • Raw JSON data for custom processing

💡 Review the workflow summary for metrics and download the artifact for complete details.

@zherbz
Copy link
Copy Markdown
Collaborator Author

zherbz commented Mar 25, 2026

@zherbz looking good overall. Notes:

  1. rioxarray needs to be added as as a dependency in env.yml and imported at the top of icechunk.py, probably with a # noqa comment to avoid getting flagged as an unused import.
import rioxarray  # noqa: F401 - needed to ensure rioxarray is registered with xarray
  1. tornado dependency needs to be upgraded to address the Docker Scout vulnerability finding.
  2. Other review comments are optional suggestions.

Thanks! All items are now addressed and ready for back-check.

@zherbz zherbz merged commit e8e75c4 into main Mar 25, 2026
9 checks passed
@zherbz zherbz deleted the feature/stormlit-lakehouse branch March 25, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants