Skip to content

feat: add optional Icon field to Goal model and implement tests#137

Open
JKASONGA1 wants to merge 3 commits intofencer-so:mainfrom
JKASONGA1:feature/add-goal-icon
Open

feat: add optional Icon field to Goal model and implement tests#137
JKASONGA1 wants to merge 3 commits intofencer-so:mainfrom
JKASONGA1:feature/add-goal-icon

Conversation

@JKASONGA1
Copy link
Copy Markdown

Summary

This PR adds icon support to the Goal model and covers the GetGoalsForUser route with unit tests.

Changes

  • Added optional Icon field (string?) to the Goal model in Goal.cs
  • Updated appsettings.json and Program.cs to connect to MongoDB Atlas
  • Updated CommBank.csproj to target net9.0
  • Implemented GetForUser unit test in GoalControllerTests.cs
  • Updated CommBank.Tests.csproj to target net9.0

Testing

  • All 11 unit tests pass (dotnet test)
  • API tested with Postman - GET /api/goal returns goals with icon field

@gitguardian
Copy link
Copy Markdown

gitguardian bot commented Mar 22, 2026

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials fcf5c30 CommBank-Server/appsettings.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants