Skip to content

Fix interceptors #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix interceptors #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94100a0
Instantiate interceptors before passing them
hussam-almarzoq Dec 10, 2022
4e4ee48
Default interceptors to empty list
hussam-almarzoq Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django_grpc_framework/management/commands/grpcrunserver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def run(self, **options):

def _serve(self):
server = grpc.server(futures.ThreadPoolExecutor(max_workers=self.max_workers),
interceptors=grpc_settings.SERVER_INTERCEPTORS)
interceptors=[interceptor() for interceptor in grpc_settings.SERVER_INTERCEPTORS])
grpc_settings.ROOT_HANDLERS_HOOK(server)
server.add_insecure_port(self.address)
server.start()
Expand Down
2 changes: 1 addition & 1 deletion django_grpc_framework/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
'ROOT_HANDLERS_HOOK': None,

# gRPC server configuration
'SERVER_INTERCEPTORS': None,
'SERVER_INTERCEPTORS': [],
}


Expand Down