-
Notifications
You must be signed in to change notification settings - Fork 39
Add fizzbuzz class with test #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vicbl
wants to merge
7
commits into
fengyuanyang:main
Choose a base branch
from
vicbl:issue-68-fizzbuzz
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
95f1ad4
Add fizzbuzz class with test
vicbl fb869e0
add test
vicbl 93b48a2
update test
vicbl 43adef3
update indentation
vicbl 0a4e2a4
update indentation
vicbl 0a8f181
Add fizzbuzz and test
vicbl 03a183f
Clean test
vicbl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package com.ordestiny.tdd.fizzbuzz; | ||
|
|
||
| public class FizzBuzz { | ||
|
|
||
| public void printFizzBuzz(int numberIteration) { | ||
| for (int i = 1; i <= numberIteration; i++) { | ||
| System.out.println(fizzBuzz(i)); | ||
| } | ||
| } | ||
|
|
||
| public String fizzBuzz(int i) { | ||
| boolean isFizz = i % 3 == 0; | ||
| boolean isBuzz = i % 5 == 0; | ||
| boolean isFizzBuzz = isFizz && isBuzz; | ||
|
|
||
| if (isFizzBuzz) { | ||
| return "FizzBuzz"; | ||
| } else if (isFizz) { | ||
| return "Fizz"; | ||
| } else if (isBuzz) { | ||
| return "Buzz"; | ||
| } else { | ||
| return String.valueOf(i); | ||
| } | ||
| } | ||
| } | ||
30 changes: 30 additions & 0 deletions
30
src/test/java/com/ordestiny/tdd/fizzbuzz/FizzBuzzTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package com.ordestiny.tdd.fizzbuzz; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| class FizzBuzzTest { | ||
|
|
||
| FizzBuzz fizzBuzz = new FizzBuzz(); | ||
|
|
||
| @Test | ||
| public void printFizzBuzz_given15Iterations_fizzBuzzIsCorrectlyPrinted() { | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you can hard cord fizzbuzz from 1 to 15 and check the result with FizzBuzz, print is not going to make any sense here |
||
| fizzBuzz.printFizzBuzz(100); | ||
| } | ||
|
|
||
| @Test | ||
| public void fizzBuzz_givenMultipleOfThree_fizzReturned() { | ||
| assertEquals("Fizz", fizzBuzz.fizzBuzz(3)); | ||
| } | ||
|
|
||
| @Test | ||
| public void fizzBuzz_givenMultipleOfFive_buzzReturned() { | ||
| assertEquals("Buzz", fizzBuzz.fizzBuzz(5)); | ||
| } | ||
|
|
||
| @Test | ||
| public void fizzBuzz_givenMultipleOfThreeAndFive_fizzBuzzReturned() { | ||
| assertEquals("FizzBuzz", fizzBuzz.fizzBuzz(15)); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print method is useless in unit tests.