Add a whole ncurses TUI and fix a delete logic bug #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every time a value is changed, parse it to update a value in the background, and possibly refresh checks (eg. node connectivity). This clarifies some phases of each argument's parsing and steps across 3 states (managed by data contents) around attributes (`unparsed` => need to check, `val` => parsed, `line` => ready to display). Node validation can time out after a while over the network, so do that check with an upper boundary on execution time. Also, to avoid inconsistencies on cursor positionment, keep label length constant.
Because of how conflicts are transmitted file by file, there's always potential for a delete conflict to happen, where 2 or more hosts have concurrently deleted a file without synchronization. We could _merge_ both deletes and bump the version, but this could run the risk of ignoring trailing conflicts in a transfer. Instead, we go explicit by adding deletion conflict messages to the protocol, and creating empty conflict files when such conflicts are detected. The user then has to delete the conflict file to resolve everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.