Daemon reliability #95
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Marking this as a draft until we can test it somewhat. |
Collaborator
Author
|
Tested under hypot instance on fifeutilgpvm03, with the patch, and then with the patch and an assert(False); it re-ran the method that was raising the exception repeatedly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we've concluded that if the routines like ferry_update() raise an exception, the pythreader TaskQueue stops running them, but keeps running the other ones... so to make the daemon more reliable we want those routines to just log any exceptions and appear to finish to the TaskQueue so it will keep running them.
Done with a log_exceptions decorator, which assumes its decorating a method of a Logged object (i.e. it has a self.log() method)