3.1 capture hot-path perf baseline (Phase 2 opener)#39
Merged
fernandoxavier02 merged 1 commit intorefactor/skill-advisor-0.5.0from Apr 27, 2026
Merged
Conversation
Slice 3.1 — Phase 2 (Hot-Path) opener. Captures p50/p95/mean wall-clock for hooks/advisor-nudge.cjs as it stands today, before the 3.3 core extraction. Locks the baseline that 3.7 will assert against (p95_atual <= baseline.p95 * 1.10). Methodology: - subprocess spawnSync per iteration (production-faithful — Claude Code invokes the hook as a child process) - 80-char and 500-char prompt corpora (PT-BR + EN tokens for 500-char to exercise tokenizer + synonym expansion) - 8 warmup iterations discarded per prompt (JIT + FS cache) - 100 sampled iterations per prompt - ADVISOR_ENABLED=true env override; advisor-config.json untouched No asserts in this slice — capture only. Baseline JSON includes runtime/environment metadata (node version, platform, index entry count, embeddings/graph availability) so 3.7 can verify same-conditions replay. tests/_perf-capture.js is rerunnable: \`node tests/_perf-capture.js\` refreshes tests/fixtures/perf-baseline.json. Leading underscore keeps it out of \`node --test tests/*.test.js\`. _Requirements: 4.2_
fernandoxavier02
merged commit 580ef16
into
refactor/skill-advisor-0.5.0
5 checks passed
Owner
Author
|
Closing — fast-forwarded Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slice 3.1 of the skill-advisor 0.5.0 refactor — Phase 2 (Hot-Path) opener. Captures p50/p95/mean wall-clock for
hooks/advisor-nudge.cjsas it stands today (pre-3.3 core extraction). Locks the baseline that slice 3.7 will assert against:p95_atual ≤ baseline.p95 × 1.10.Capture-only — no asserts in this slice (per spec).
What ships
tests/_perf-capture.js— rerunnable subprocess-spawn baseline harness. Leading_keeps it out ofnode --test tests/*.test.js. Re-run withnode tests/_perf-capture.jsto refresh the baseline JSON.tests/fixtures/perf-baseline.json— schema-versioned baseline with runtime + environment metadata (node version, platform, index entry count, embeddings/graph availability) so 3.7 can verify same-conditions replay.Methodology
spawnSyncper iteration_perf-harness.jsdefault.ADVISOR_ENABLED=trueenv overrideadvisor-config.jsonenabled: falsedefault without mutating the config file.Captured baseline (this run)
Environment: Node v22.22.2 / linux x64, 1 indexed entry, graph available, embeddings unavailable. Slice 3.7 must replay under same
npm run indexconditions for an apples-to-apples comparison.Test plan
npm cinpm run index(1 entry indexed — deterministic on this host)node tests/_perf-capture.jsproducestests/fixtures/perf-baseline.jsonnpm run validate— 681/681 tests pass, smoke-runner exits 0Requirements: 4.2
Generated by Claude Code