Conversation
|
Out of curiosity, what is the benefit of this migration to streamx? Edit: Disregard, I see the discussion: webtorrent/webtorrent#1971 |
|
@feross any concerns about merging this? |
yes, it's broken as streamx handles stream states differently, and I don't know how to fix it, there are like 11 other PR's in the webtorrent ecosystem before this one which are actually working |
|
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain:
What changes did you make? (Give an overview)
Migrated to streamx
Which issue (if any) does this pull request address?
webtorrent/webtorrent#1971
Is there anything you'd like reviewers to focus on?
Tests.
Previously this forced
Buffer, now it's... whatever the browser yields. This causes 2 tests to fail.Node readable state's are different from streamx's readable states. This causes 4 tests to fail, as I likely edited the code for these changes and tests incorrectly, I'm not certain how to handle this.