Support for Sodium(NeoForge), Fix Iris incompatibility#38
Merged
ferriarnus merged 5 commits intoferriarnus:1.21from Jan 28, 2025
Merged
Support for Sodium(NeoForge), Fix Iris incompatibility#38ferriarnus merged 5 commits intoferriarnus:1.21from
ferriarnus merged 5 commits intoferriarnus:1.21from
Conversation
Author
|
This PR will fix issue #31 |
|
i thank you for this so much |
Owner
|
Thank you for the PR, I'll try to have a look the next few days! |
|
So how's this goin |
Owner
|
I've been trying to fix some other bugs and do a big release, but maybe I should just fix this and look into the other stuff later, it's taking me too long now. |
Owner
|
Thanks again for making this. You should be able to get a beta from the github actions, and I'll see to get it on CF soon, I need to test if everything is working now (also on the older builds) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sodium has already have releases that runs natively on NeoForge, this PR adds support for Sodium's Flawless Frames. Also, recent issues about iris incompatibility is due to SecureJar loading too early during mixin phase, this PR moves actual code out of the mixin class so mixin won't access the SecureJar while transforming the class. This PR has been tested using sodium-mc1.21.1-0.6.0-beta.4-neoforge and iris-1.8.0-beta.5+1.21-neoforge on NeoForge 21.1.63.