Skip to content

Conversation

@fewieden
Copy link
Owner

@fewieden fewieden commented Feb 13, 2024

[Unreleased]

Requires version >= 18 of NodeJS!

Fixed

Added

Changed

  • Use logger instead of console
  • Updated dependencies
  • Updated reference to new GitHub repository of MagicMirror² project

Removed

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d255ec6) to head (b1e0640).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           97        97           
=========================================
  Hits            97        97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated

## Dependencies

* An installation of [MagicMirror²](https://github.com/MichMich/MagicMirror)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node_helper.js Outdated
* @external node-fetch
* @see https://www.npmjs.com/package/node-fetch
* @external logger
* @see https://github.com/MichMich/MagicMirror/blob/master/js/logger.js

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated
"la liga",
"ligue 1",
"eredivisie",
"primeira liga"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the new module list we are using sport like a main category. So it would be nice if you add it as keyword.

@KristjanESPERANTO
Copy link

I hope it's okay that I've taken the opportunity to add a few comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants