Skip to content

add roadmap override check #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hefangshi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add roadmap override check #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 52 additions & 1 deletion lib/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,44 @@ function merge(source, target){
return source;
}

function checkRoadmapPath(origin, roadmapPath, stack){

function getRoadmapPathSummary(roadmapPath){
var info = roadmapPath.map(function(c){
return c.reg;
}).slice(0, 5);
if (roadmapPath.length > 5){
info.push('...');
}
return info.join(', ');
}

function getStackInfo(stack){
var stacks = stack.split('\n');
if (stacks.length < 2){
return '';
}
//stacks[2] is the fis-conf stack
var fisConfStack = stacks[2];
var info = fisConfStack.match(/\((.*)\)/);
if (info.length < 1){
return '';
}
return ' at ' + info[1];
}

if (origin.roadmap && origin.roadmap.path){
fis.log.warning(
'roadmap.path [' +
getRoadmapPathSummary(origin.roadmap.path) +
'] was overrided by [' +
getRoadmapPathSummary(roadmapPath) +
']' + getStackInfo(stack) +
', please use fis.config.get(\'roadmap.path\').unshift(ruler) to add rulers.');
console.log()
}
}

var Config = Object.derive({
constructor : function(){
this.init.apply(this, arguments);
Expand All @@ -56,8 +94,17 @@ var Config = Object.derive({
},
set : function(path, value){
if(typeof value === 'undefined'){
if (path.roadmap && path.roadmap.path){
checkRoadmapPath(this.data, path, (new Error()).stack);
}
this.data = path;
} else {
if (path === 'roadmap.path'){
checkRoadmapPath(this.data, value, (new Error()).stack);
}
if (path === 'roadmap' && value.path){
checkRoadmapPath(this.data, value.path, (new Error()).stack);
}
path = String(path || '').trim();
if(path){
var paths = path.split('.'),
Expand All @@ -70,7 +117,7 @@ var Config = Object.derive({
} else if(type === 'undefined'){
data = data[key] = {};
} else {
fis.log.error('forbidden to set property[' + key + '] of [' + type + '] data');
fis.log.error('forbidden to set property [' + key + '] of [' + type + '] data');
}
});
data[last] = value;
Expand Down Expand Up @@ -100,8 +147,12 @@ var Config = Object.derive({
},
merge : function(){
var self = this;
var stack = (new Error()).stack;
[].slice.call(arguments).forEach(function(arg){
if(typeof arg === 'object'){
if (arg.roadmap && arg.roadmap.path){
checkRoadmapPath(self.data, arg.roadmap.path, stack);
}
merge(self.data, arg);
} else {
fis.log.warning('unable to merge data[' + arg + '].');
Expand Down