Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Harvest 上で同一クエストが複数ページ ID に分割されるケースに対応するため、クエスト定義に「集計元ページIDの複数指定」を追加し、集計 Lambda 側でマージ集計できるようにするPRです。
Changes:
quests[].sourceQuestIds（省略可）を Quest 型と仕様書に追加- 集計 Lambda が
sourceQuestIdsから複数ページのレポートを取得し、重複排除してマージ - 管理画面で
sourceQuestIdsを編集・候補から「ソースとして追加」できるUIを追加し、Lambda 側のテストを追加
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| viewer/src/types.ts | Quest 型に sourceQuestIds?: string[] を追加し、フロント側で新フィールドを許容 |
| admin/src/types/index.ts | 管理画面側 Quest 型に sourceQuestIds?: string[] を追加 |
| admin/src/pages/EventFormPage.tsx | sourceQuestIds の編集UIと、Harvest候補を「ソースに追加」する操作を追加 |
| lambda/aggregator/handler.py | sourceQuestIds に基づく複数ソース取得・重複排除・マージ処理を追加 |
| lambda/aggregator/test_handler.py | process_quest の複数ソース対応のユニットテストを追加 |
| SPEC.md | sourceQuestIds の仕様と、Harvestページ分割(1:N)の挙動を追記 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rid が空文字(falsy)の場合は seen_ids に追加しないよう修正。 重複排除の意図が明確になり、将来のロジック変更時の誤動作を防ぐ。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
sourceExpanded / newSourceId / addAsSourceTarget が配列インデックスを キーに持つため、クエスト削除でインデックスがずれる問題を修正。 removeQuest でインデックスを詰め直すことで対応。 また addAsSource に範囲外インデックスのガードを追加。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.