Add methods for COV notification sending #143
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 3, 2019 18:13
Resolve "add cov notification" Closes fh1ch#1 See merge request SystemX/testing/node-bacstack!1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
What does this Pull Request do
Adds client methods for sending confirmed and unconfirmed COV notifications.
I tried to make as less changes a possible to not brake any API or consistency. Therefore the methods have separate parameters for all notification data and not a single notification object. This way it keeps consistent with the subscribe method.
A separate refactoring, to have a single object parameter for all the notification data, of the subcribeCOV and COVNotification method should be done. Like in the eventNotification method.