Skip to content

Added support for multiple subscriptions in channels "QUOTES" and "TR… #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jontesehlin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for multiple subscriptions in channels "QUOTES" and "TR… #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,6 @@ old/

# dist folder only deployed on npm
dist/

#Visual Studio
.vs/
47 changes: 38 additions & 9 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,12 +360,24 @@ class Avanza extends EventEmitter {
_socketSubscribe(subscriptionString) {
this._socketSubscriptions[subscriptionString] = null
if (this._socketConnected) {
this._socketSend({
channel: '/meta/subscribe',
clientId: this._socketClientId,
id: this._socketMessageCount,
subscription: subscriptionString
})
const subscriptionStrings = subscriptionString.split(',')
if (subscriptionStrings.length > 1) {
subscriptionStrings.forEach((subString) => {
this._socketSend({
channel: '/meta/subscribe',
clientId: this._socketClientId,
id: this._socketMessageCount,
subscription: subString
})
})
} else {
this._socketSend({
channel: '/meta/subscribe',
clientId: this._socketClientId,
id: this._socketMessageCount,
subscription: subscriptionString
})
}
}
}

Expand Down Expand Up @@ -666,25 +678,42 @@ class Avanza extends EventEmitter {
throw new Error('Expected to be authenticated before subscribing.')
}

const subscriptionStrings = []
if (Array.isArray(ids)) {
if (
channel === Avanza.ORDERS ||
channel === Avanza.DEALS ||
channel === Avanza.POSITIONS
) {
ids = ids.join(',')
const subscriptionString = `/${channel}/${ids}`
subscriptionStrings.push(subscriptionString)
} else if (
channel === Avanza.QUOTES ||
channel === Avanza.TRADES
) {
ids.forEach((id) => {
const subscriptionString = `/${channel}/${id}`
subscriptionStrings.push(subscriptionString)
})
} else {
throw new Error(`Channel ${channel} does not support multiple ids as input.`)
}
} else {
const subscriptionString = `/${channel}/${ids}`
subscriptionStrings.push(subscriptionString)
}

const _this = this;
subscriptionStrings.forEach((subscriptionString) => {
_this.on(subscriptionString, data => callback(data))
})

if (!this._socket) {
this._socketInit()
}

const subscriptionString = `/${channel}/${ids}`
this.on(subscriptionString, data => callback(data))
this._socketSubscribe(subscriptionString)
this._socketSubscribe(subscriptionStrings)
}

/**
Expand Down